New issue
Advanced search Search tips

Issue 806934 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 177475



Sign in to add a comment

autofill_metrics.cc GetFieldTypeGroupMetric() does the wrong thing for ADDRESS_HOME_STREET_ADDRESS

Project Member Reported by thakis@chromium.org, Jan 29 2018 
https://codereview.chromium.org/1821053002/diff/100001/components/autofill/core/browser/autofill_metrics.cc line 103 added

  case ADDRESS_HOME_STREET_ADDRESS:
    group = GROUP_STREET_ADDRESS;

but it didn't add a break;, so group is always overwritten with GROUP_ADDRESS_CITY immediately.

I don't know what the repercussions of this are.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5617cbef1c007787026373eb7f136574f6cdf34e

commit 5617cbef1c007787026373eb7f136574f6cdf34e
Author: sebsg <sebsg@chromium.org>
Date: Mon Jan 29 20:43:47 2018

[Autofill] Fix metrics groups bug.

The case statement was missing a break.

Bug:  806934 
Change-Id: I7e51f35a1e418439e7577e757fd5daf182d6c6a7
Reviewed-on: https://chromium-review.googlesource.com/891690
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532574}
[modify] https://crrev.com/5617cbef1c007787026373eb7f136574f6cdf34e/components/autofill/core/browser/autofill_metrics.cc

Comment 2 by thakis@chromium.org, Jan 29 2018

Status: Fixed (was: Unconfirmed)
thanks!

Comment 3 by se...@chromium.org, Jan 30 2018 

Thank you for flagging this!

Comment 4 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment