New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 806926 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SandboxedUnpacker may hit a NOTREACHED on some errors.

Project Member Reported by jcivelli@chromium.org, Jan 29 2018 
SandboxedUnpacker::MessageCatalogsSanitized() does fall through some error cases triggering a NOTREACHED.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f54e7ce307438ed784d60b56f84fda1a054cc86

commit 1f54e7ce307438ed784d60b56f84fda1a054cc86
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Jan 29 19:19:05 2018

Fix fallthrough in SandboxedUnpacker.

SandboxedUnpacker::MessageCatalogsSanitized() does fall through some
error cases triggering a NOTREACHED.

Bug:  806926 , 177475 
Change-Id: I9aaf62d1197a5885ab8871ca93197c6cb11cfdac
Reviewed-on: https://chromium-review.googlesource.com/891620
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532532}
[modify] https://crrev.com/1f54e7ce307438ed784d60b56f84fda1a054cc86/extensions/browser/sandboxed_unpacker.cc

Comment 2 by jcivelli@chromium.org, Jan 29 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment