New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 806921 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: Jan 2018
Cc:
s...@chromium.org
█ rkaplow@chromium.org
pav...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 177475



Sign in to add a comment

https://codereview.chromium.org/2701003002 accidentally removed break after case SUPERVISED_USER_SHARED_SETTINGS:

Project Member Reported by thakis@chromium.org, Jan 29 2018 
@@ -269,21 +249,39 @@
       break;
     case SUPERVISED_USER_SHARED_SETTINGS:
       specifics->mutable_managed_user_shared_setting();
-      break;
-    case SUPERVISED_USER_WHITELISTS:
-      specifics->mutable_managed_user_whitelist();
-      break;

https://codereview.chromium.org/2701003002/diff/140001/components/sync/syncable/model_type.cc

So case SUPERVISED_USER_SHARED_SETTINGS: always falls through to the case ARTICLES. I don't know what the repercussions of that are, but it looks unintentional.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d877575f265b60d1a412d6a01dc2d6eb8dc8d0

commit 47d877575f265b60d1a412d6a01dc2d6eb8dc8d0
Author: Nico Weber <thakis@chromium.org>
Date: Tue Jan 30 20:51:55 2018

Remaining changes to build all code in src.git with -Wimplicit-fallthrough.

Fixes a missing break that was accidentally deleted in
https://codereview.chromium.org/2701003002/diff/140001/components/sync/syncable/model_type.cc
which caused each SUPERVISED_USER_SHARED_SETTINGS to also receive an
ARTICLES default value.

This CL was uploaded by git cl split.

R=zea@chromium.org

Bug:  177475 , 806921 
Change-Id: Iaa5b42a8d2ac5787b787b6163adb2f3f7407e6c8
Reviewed-on: https://chromium-review.googlesource.com/891746
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533017}
[modify] https://crrev.com/47d877575f265b60d1a412d6a01dc2d6eb8dc8d0/components/sync/syncable/model_type.cc

Comment 2 by thakis@chromium.org, Jan 30 2018

Cc: s...@chromium.org
Owner: thakis@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment