New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806918 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[remoting host] Crash (SIGFPE) in remoting::LeakyBucket::GetEmptyTime()

Project Member Reported by lambroslambrou@chromium.org, Jan 29 2018

Issue description

Crash seen occasionally with our Perf framework. Managed to repro locally against ToT debug build. Repro steps are: connect to the host via WebRTC, play a video or do some other stress test, and wait.

GDB stack trace attached.

 
gdb.txt
39.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b

commit e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Mon Jan 29 20:20:57 2018

[remoting host] Fix div-by-zero in LeakyBucket

When receiving a bandwidth estimate of 0 from WebRTC, the host should
pause the video stream without crashing. This CL is a simple fix which
sets the bucket-emptying time to 1 minute if the rate is set to 0. This
is similar to what we already do in
FrameProcessingTimeEstimator::EstimatedTransitTime().

Bug:  806918 
Change-Id: I43bf24cf54250cc3856adeb4c49809733320d46b
Reviewed-on: https://chromium-review.googlesource.com/891671
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532567}
[modify] https://crrev.com/e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b/remoting/base/leaky_bucket.cc

Labels: -Pri-3 Merge-Request-65 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Requesting merge of revision e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b into M65.
This fixes a crash in remoting host process. It's a trivial, safe change which has no effect on Chrome browser.

Project Member

Comment 3 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 31 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486d7d0128db8e9fd17f90eab40143aefae0d76e

commit 486d7d0128db8e9fd17f90eab40143aefae0d76e
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Wed Jan 31 21:31:22 2018

[remoting host] Fix div-by-zero in LeakyBucket

When receiving a bandwidth estimate of 0 from WebRTC, the host should
pause the video stream without crashing. This CL is a simple fix which
sets the bucket-emptying time to 1 minute if the rate is set to 0. This
is similar to what we already do in
FrameProcessingTimeEstimator::EstimatedTransitTime().

Bug:  806918 
Change-Id: I43bf24cf54250cc3856adeb4c49809733320d46b
Reviewed-on: https://chromium-review.googlesource.com/891671
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532567}(cherry picked from commit e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b)
Reviewed-on: https://chromium-review.googlesource.com/896162
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#213}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/486d7d0128db8e9fd17f90eab40143aefae0d76e/remoting/base/leaky_bucket.cc

Status: Fixed (was: Started)

Sign in to add a comment