New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806915 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Report error for invalid PPD in UI

Project Member Reported by valleau@chromium.org, Jan 29 2018

Issue description

In  crbug.com/778462  a simple verification of user-provided PPDs is being added to the printing page.

When the user provides an invalid PPD we should display an error message and allow them to select a different file without having to restart the form.
 

Comment 1 by skau@chromium.org, Feb 2 2018

Status: Started (was: Assigned)

Comment 2 by skau@chromium.org, Feb 15 2018

Did you land this change or is it still pending?
I had a final comment that I just addressed, sent it now I'll mark this as fixed when it lands.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1d7dbb9fd410420786fe38110913448f6110dc

commit 7f1d7dbb9fd410420786fe38110913448f6110dc
Author: David Valleau <valleau@chromium.org>
Date: Fri Feb 16 02:54:53 2018

Adding error message for when a user selects an invalid PPD file

This change is built off of https://crrev.com/c/887858 which added basic
verification to user-selected PPD files in order to provide them with
more immediate feedback when they select an invalid file. This change is
simply adding an error message that is displayed to the user.

Here are some screenshots of what this change looks like in the UI:

  - invalid PPD (https://screenshot.googleplex.com/YKH4CPFTJpV.png)
  - valid PPD (https://screenshot.googleplex.com/ube7K8v9QtT.png)

R=dpapad@chromium.org, xdai@chromium.org

Bug:  778462 , 806915 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6992a594cbf0c086e136c32814b8070724b1ed71
Reviewed-on: https://chromium-review.googlesource.com/898432
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537151}
[modify] https://crrev.com/7f1d7dbb9fd410420786fe38110913448f6110dc/chrome/app/settings_strings.grdp
[modify] https://crrev.com/7f1d7dbb9fd410420786fe38110913448f6110dc/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/7f1d7dbb9fd410420786fe38110913448f6110dc/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.js
[modify] https://crrev.com/7f1d7dbb9fd410420786fe38110913448f6110dc/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)
Cc: justincarlson@chromium.org
 Issue 782984  has been merged into this issue.

Sign in to add a comment