Omnibox cursor disappears under voice search icon |
||||
Issue descriptionAs of now, filling the omnibox with text sees the cursor (and text) disappear under the voice search button on the right end of the box. This is because the text field doesn't resize according to the presence of the voice button. This is a relatively simple size dependence. We could fix it by binding the omnibox field width to incognito mode, or, we could improve linear layouts to support a fixed width ( issue 806886 ).
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12dc6f53292f756a16368e92b35af0705138645b commit 12dc6f53292f756a16368e92b35af0705138645b Author: Christopher Grant <cjgrant@chromium.org> Date: Tue Feb 13 20:58:50 2018 VR: Ensure omnibox text does not overlap voice button Until now, a lengthy text input in the omnibox would disappear under the voice button on the right end of the bar. Size things so that this doesn't happen. In the future, we should use linear layout capabilities to automate this (a bug tracking that improvement exists). BUG= 806889 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I28714cba111b42d0ecf1900c873aa1856ad1c572 Reviewed-on: https://chromium-review.googlesource.com/916862 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#536469} [modify] https://crrev.com/12dc6f53292f756a16368e92b35af0705138645b/chrome/browser/vr/elements/ui_element_type.cc [modify] https://crrev.com/12dc6f53292f756a16368e92b35af0705138645b/chrome/browser/vr/elements/ui_element_type.h [modify] https://crrev.com/12dc6f53292f756a16368e92b35af0705138645b/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/12dc6f53292f756a16368e92b35af0705138645b/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/12dc6f53292f756a16368e92b35af0705138645b/chrome/browser/vr/ui_unittest.cc
,
Feb 13 2018
,
Feb 14 2018
Added testcase "Text scrolling in Omnibox" to the "VR Browsing: Omnibox text entry manual test plan"
,
Feb 14 2018
Verified in build 66.0.3347.0 canary. |
||||
►
Sign in to add a comment |
||||
Comment 1 by cjgrant@chromium.org
, Feb 2 2018