Issue metadata
Sign in to add a comment
|
1.5% regression in smoothness.key_mobile_sites_smooth at 531737:531783 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 29 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11fea50a840000
,
Jan 29 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11fea50a840000
,
Feb 5 2018
,
Feb 12 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12cd16cd840000
,
Feb 12 2018
,
Feb 13 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12cd16cd840000 cc: Don't clamp tex coords for nearest neighbor filtering by enne@chromium.org https://chromium.googlesource.com/chromium/src/+/0a7947a6984a2131616c5c24e7c6c4043ba60eb2 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac2b2c6531e82191b77795f62280acddbf098c05 commit ac2b2c6531e82191b77795f62280acddbf098c05 Author: Adrienne Walker <enne@chromium.org> Date: Tue Apr 03 18:58:24 2018 viz: Use texture clamping shader always https://chromium-review.googlesource.com/c/chromium/src/+/883944 restricted how often we would use shaders that clamped tex coords. However, this confusingly regressed perf a little bit on Android, which implies that program switching is expensive. This patch changes GLRenderer to always texture clamp these quads which reduces the number of shaders we use. Bug: 806836 , 806826 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b2e71b362d6a12f17758abe2edddf1759536016 Reviewed-on: https://chromium-review.googlesource.com/972546 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547780} [modify] https://crrev.com/ac2b2c6531e82191b77795f62280acddbf098c05/components/viz/service/display/gl_renderer.cc [modify] https://crrev.com/ac2b2c6531e82191b77795f62280acddbf098c05/content/test/gpu/gpu_tests/pixel_expectations.py
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d669cd65fee123b17f001052130fe9ce43a21bd4 commit d669cd65fee123b17f001052130fe9ce43a21bd4 Author: Adrienne Walker <enne@chromium.org> Date: Fri Apr 06 22:09:13 2018 Revert "viz: Use texture clamping shader always" This reverts commit ac2b2c6531e82191b77795f62280acddbf098c05. Reason for revert: causes texture filtering issues, even when the clamp value is infinite. Bug: 828736 Original change's description: > viz: Use texture clamping shader always > > https://chromium-review.googlesource.com/c/chromium/src/+/883944 > restricted how often we would use shaders that clamped tex coords. > However, this confusingly regressed perf a little bit on Android, > which implies that program switching is expensive. > > This patch changes GLRenderer to always texture clamp these quads > which reduces the number of shaders we use. > > Bug: 806836 , 806826 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I2b2e71b362d6a12f17758abe2edddf1759536016 > Reviewed-on: https://chromium-review.googlesource.com/972546 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547780} TBR=kbr@chromium.org,enne@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806836 , 806826 Change-Id: Ib12b7439cc8b1de70b39b42c43bc3b7f34f5dd92 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/998805 Commit-Queue: enne <enne@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#548944} [modify] https://crrev.com/d669cd65fee123b17f001052130fe9ce43a21bd4/components/viz/service/display/gl_renderer.cc [modify] https://crrev.com/d669cd65fee123b17f001052130fe9ce43a21bd4/content/test/gpu/gpu_tests/pixel_expectations.py
,
Apr 6 2018
Tried fixing, ran into driver bugs. This is a small enough regression that I don't think it's worth chasing this one in particular. I think we could probably stand to investigate batching tiles and program usage at a higher level anyway. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 29 2018