Issue metadata
Sign in to add a comment
|
10%-10.7% regression in blink_perf.layout at 531992:532076 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 29 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16fe1fea840000
,
Mar 3 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16b8c9b4440000
,
Mar 3 2018
Re-running the bisect job since it didn't complete, but the results in #2 look pretty clear that there is a regression at r532004, "Implement conditional copy/move ctors/assign-operators." hidehiko, can you take a look?
,
Mar 6 2018
sullivan@, I don't have win dev env set up. Is it possible to run perf test on bots for a CL which is not yet landed for testing?
,
Mar 6 2018
crrev.com/c/951024 is the potential fix if r532004 is actual cause, so I'd like to give it a try to run the test. danakj@, BTW, regardless of this issue, I think we should have such a change anyway, so I have sent a CL to review.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4aa16b9dfd1acc518bad647b5f551eaa72ed0b0 commit c4aa16b9dfd1acc518bad647b5f551eaa72ed0b0 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Mar 07 03:45:37 2018 Enable Empty-Base-Class optimization for Win. On windows build, empty base class optimization does not work by default, thus empty struct trick to implement conditional {copy,move}{constructor,assign-operator} causes unexpected Optional class size increasing. This CL fixes it. BUG= 806831 TEST=Trybot. Change-Id: I712b949b55a75d1ce23f032d2223258f744350c5 Reviewed-on: https://chromium-review.googlesource.com/951024 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#541313} [modify] https://crrev.com/c4aa16b9dfd1acc518bad647b5f551eaa72ed0b0/base/optional.h [modify] https://crrev.com/c4aa16b9dfd1acc518bad647b5f551eaa72ed0b0/base/optional_unittest.cc
,
Mar 10 2018
📍 Found significant differences after each of 5 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16b8c9b4440000 Implement conditional copy/move ctors/assign-operators. by hidehiko@chromium.org https://chromium.googlesource.com/chromium/src/+/5cae9645215d02cb1f986a181a208f8a4817fc86 Add test for purge of UKM logs when consent is revoked. by bcwhite@chromium.org https://chromium.googlesource.com/chromium/src/+/da9945e142b70f951f933fc32009740fc39cd2b0 Landing Recent QUIC changes until 1:12 PM, Jan 19, 2018 UTC-8 by zhongyi@chromium.org https://chromium.googlesource.com/chromium/src/+/d372280b432c74f278faeddfcd5ec59f65fe17cf Update WebFrame::VisibleContentRect for RLS. by skobes@chromium.org https://chromium.googlesource.com/chromium/src/+/a1dceecc377acf195a2794851a9340279faf0cf1 Add UKM metrics for rendering timing measurements by cbiesinger@chromium.org https://chromium.googlesource.com/chromium/src/+/a324bac1171a6d35eb9fe367529300aabc3ae1f2 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 19 2018
My change has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/892482 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 29 2018