New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806792 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

CustomTabFromChromeExternalNavigationTest#testIntentWithRedirectToApp fails on Android N

Reported by mirko.r...@mips.com, Jan 29 2018

Issue description

Steps to reproduce the problem:
1. Use Android N (I used Nexus 10 with custom rom for Nougat 7.1.1, but it can also be reproduced on qemu with Nougat 7.1.1)
2. ./out/Release/bin/run_chrome_public_test_apk -f org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest#testIntentWithRedirectToApp

What is the expected behavior?
Test to pass

What went wrong?
Test failed with error:
C   34.597s Main  [FAIL] org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest#testIntentWithRedirectToApp:
C   34.597s Main  java.lang.AssertionError: Values did not match. Expected: OVERRIDE_WITH_EXTERNAL_INTENT, actual: NO_OVERRIDE
C   34.597s Main  	at org.junit.Assert.fail(Assert.java:88)
C   34.598s Main  	at org.junit.Assert.assertTrue(Assert.java:41)
C   34.598s Main  	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
C   34.598s Main  	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
C   34.598s Main  	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:194)
C   34.598s Main  	at org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp(CustomTabFromChromeExternalNavigationTest.java:153)
C   34.598s Main  	at java.lang.reflect.Method.invoke(Method.java)
C   34.598s Main  	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
C   34.598s Main  	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
C   34.598s Main  	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
C   34.598s Main  	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
C   34.598s Main  	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
C   34.598s Main  	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
C   34.598s Main  	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
C   34.598s Main  	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:113)
C   34.598s Main  	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
C   34.598s Main  	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
C   34.598s Main  	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
C   34.598s Main  	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
C   34.598s Main  	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
C   34.598s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
C   34.598s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
C   34.598s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C   34.598s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C   34.598s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C   34.598s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C   34.598s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C   34.598s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C   34.598s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
C   34.598s Main  	at org.junit.runners.Suite.runChild(Suite.java:128)
C   34.599s Main  	at org.junit.runners.Suite.runChild(Suite.java:27)
C   34.599s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C   34.599s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C   34.599s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C   34.599s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C   34.599s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C   34.599s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C   34.599s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
C   34.599s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
C   34.599s Main  	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
C   34.599s Main  	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
C   34.599s Main  	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:99)
C   34.599s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)

Did this work before? N/A 

Chrome version: Top of master  Channel: dev
OS Version: Nougat 7.1.1
Flash Version:
 
Components: UI>Browser>Mobile>CustomTabs
Cc: yolandyan@chromium.org ligim...@chromium.org
Labels: M-66 FoundIn-66 Target-66
Owner: tedc...@chromium.org
Status: Assigned (was: Unconfirmed)
Looks like the test fails at CustomTabFromChromeExternalNavigationTest.java:153

Based on the code search, looping to feature owners.
Labels: -Pri-2 Pri-3
Status: Available (was: Assigned)
That test requires Google Maps to be on the device, which is true on our test fleet.  I suspect you're running on a device w/o that?
That is correct. I have tried it with google maps installed and the test is passing now. Thank you.
Status: WontFix (was: Available)
Going to close this out for now.  We could potentially not run the test if we detect maps isn't there, but that has the risk that the test could eventually start not being run unexpectedly and we wouldn't catch anything.

Having the dependency on maps is definitely less than ideal, but it's "ok" for now.

Sign in to add a comment