Expose concept of signout via IdentityManager |
||||||||
Issue descriptionWill be necessary to convert usages of SigninManager::SignOut(). One particular item of interest is how this flow will interact with IdentityManager's cached primary account information: Should it clear the primary account information when invoking the signout call on the Identity Service or only when receiving the callback from the Identity Service that the signout event was processed?
,
Feb 5 2018
,
Feb 5 2018
,
Feb 5 2018
,
Feb 9 2018
,
Jul 16
As a first step here we will be wrapping SigninManager::SignOut() with IdentityManager::ClearPrimaryAccount() (at the C++ level).
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f93c62cc61886548a16b0c73a6d6b0fca9d0d65 commit 5f93c62cc61886548a16b0c73a6d6b0fca9d0d65 Author: chcunningham <chcunningham@chromium.org> Date: Thu Aug 02 15:27:33 2018 Signin for UserPolicy Signin/Signout Tests Adds call to SigninManager::SignIn(...) as part of TestSuccessfulSignin helper method. This is needed to simulate real signin and becomes critical with upcoming changes* to FakeSigninManager. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I973859ef52bcddd978429dbb4ce9d913224c7b0d Reviewed-on: https://chromium-review.googlesource.com/1160492 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580194} [modify] https://crrev.com/5f93c62cc61886548a16b0c73a6d6b0fca9d0d65/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c0a4b4e4fcdb18f1e3710e00cf0ebde46b8d4f3 commit 4c0a4b4e4fcdb18f1e3710e00cf0ebde46b8d4f3 Author: chcunningham <chcunningham@chromium.org> Date: Thu Aug 02 15:51:17 2018 Initialize SigninManager for ios AccountConsistencyServiceTest The (Fake)SigninManager should always be initialized before using. This is made more critical by upcoming changes* that will cause the test to fail if initialization is not performed. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I06989a895f86b3ca9b1b84760b54ecafdaafdb03 Reviewed-on: https://chromium-review.googlesource.com/1160643 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580204} [modify] https://crrev.com/4c0a4b4e4fcdb18f1e3710e00cf0ebde46b8d4f3/components/signin/ios/browser/account_consistency_service_unittest.mm
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e47d3c954e6b0b1752e214756eebd62334e71cf commit 7e47d3c954e6b0b1752e214756eebd62334e71cf Author: chcunningham <chcunningham@chromium.org> Date: Fri Aug 03 10:52:40 2018 Improve FakeSigninManager::DoSignout() - Check IsAuthenticated This brings the fake a little closer to real SigninManager. The added behavior is critical to *upcoming tests for the IdentityMager ClearPrimaryAccount() (aka signout) API. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I4d533e67223dfe4bce6ca26eee7aea6f7cc075fd Reviewed-on: https://chromium-review.googlesource.com/1160495 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#580500} [modify] https://crrev.com/7e47d3c954e6b0b1752e214756eebd62334e71cf/components/signin/core/browser/fake_signin_manager.cc
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a30be7d24c1af512ae21eb74df991c26694fdbfe commit a30be7d24c1af512ae21eb74df991c26694fdbfe Author: chcunningham <chcunningham@chromium.org> Date: Fri Aug 03 11:12:28 2018 New constructor overloads for FakeSigninManager Splitting this out of review https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I0221d901537e39e2c2d66adca254b3ff77df4823 Reviewed-on: https://chromium-review.googlesource.com/1160497 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#580502} [modify] https://crrev.com/a30be7d24c1af512ae21eb74df991c26694fdbfe/components/signin/core/browser/fake_signin_manager.cc [modify] https://crrev.com/a30be7d24c1af512ae21eb74df991c26694fdbfe/components/signin/core/browser/fake_signin_manager.h
,
Aug 3
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc792ae009004f77619157c55ef0912b0d0ae00 commit 9dc792ae009004f77619157c55ef0912b0d0ae00 Author: chcunningham <chcunningham@chromium.org> Date: Fri Aug 03 13:03:29 2018 Implement IdentityManager::ClearPrimaryAccount(...) Another step on the path to deprecating SigninManager. This method replaces SigninManager::SignOut*(). See design discussion here: https://groups.google.com/a/chromium.org/d/msg/identity-service-dev/hNrtJ_nIXJ4/6nMXfIcVBwAJ Bug: 806781 Test: New unit tests Change-Id: I39fe49925c980362b0cdf58db2ce961e107241b6 Reviewed-on: https://chromium-review.googlesource.com/1154985 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#580519} [modify] https://crrev.com/9dc792ae009004f77619157c55ef0912b0d0ae00/services/identity/public/cpp/DEPS [modify] https://crrev.com/9dc792ae009004f77619157c55ef0912b0d0ae00/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/9dc792ae009004f77619157c55ef0912b0d0ae00/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/9dc792ae009004f77619157c55ef0912b0d0ae00/services/identity/public/cpp/identity_manager_unittest.cc
,
Aug 13
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by blundell@chromium.org
, Jan 29 2018Components: Internals>Services>Identity
Status: Available (was: Untriaged)