Provide IdentityManager observer methods for refresh token being made available/revoked |
||||||||||
Issue descriptionThese will be for converting usages of the OAuth2TokenService observer callbacks that a refresh token was made available/revoked. We probably don't want them to talk in terms of refresh tokens but rather about accounts being available/no longer available.
,
Feb 5 2018
,
Feb 5 2018
,
Feb 5 2018
,
Feb 6 2018
,
Apr 19 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46a15abd9382ae51aabc3b16823b4724b7f93b50 commit 46a15abd9382ae51aabc3b16823b4724b7f93b50 Author: Marc Treib <treib@chromium.org> Date: Tue Apr 24 15:10:08 2018 Fix DCHECKs in IdentityManager::GetPrimaryAccountInfo On ChromeOS, IdentityManager::GetPrimaryAccountInfo DCHECKs that its view of the primary account info matches the one in SigninManagerBase. However, if the primary account's refresh token gets revoked, then the account gets removed from the AccountTrackerService, and SigninManagerBase will only remember the account's ID, but not the full AccountInfo. This CL updates the DCHECKs so that they only verify the account ID in this case. Bug: 825190 , 806775 Change-Id: I6cbde518e064b590109ef8ca165a1106c7ebda83 Reviewed-on: https://chromium-review.googlesource.com/1025094 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#553116} [modify] https://crrev.com/46a15abd9382ae51aabc3b16823b4724b7f93b50/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/46a15abd9382ae51aabc3b16823b4724b7f93b50/services/identity/public/cpp/identity_manager.cc
,
May 8 2018
,
Jun 12 2018
Colin, can this be considered done after https://crrev.com/c/1076047?
,
Jun 13 2018
Whoops, yes! Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1076047.
,
Dec 10
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by blundell@chromium.org
, Jan 29 2018Components: Internals>Services>Identity
Status: Available (was: Untriaged)