New issue
Advanced search Search tips

Issue 806775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544
issue 809539
issue 808986
issue 809031
issue 840703



Sign in to add a comment

Provide IdentityManager observer methods for refresh token being made available/revoked

Project Member Reported by blundell@chromium.org, Jan 29 2018

Issue description

These will be for converting usages of the OAuth2TokenService observer callbacks that a refresh token was made available/revoked. We probably don't want them to talk in terms of refresh tokens but rather about accounts being available/no longer available.
 
Blocking: 796544
Components: Internals>Services>Identity
Status: Available (was: Untriaged)
Blocking: 808986
Blocking: 808989
Blocking: 809031
Blocking: 809539

Comment 6 by treib@chromium.org, Apr 19 2018

Cc: treib@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a15abd9382ae51aabc3b16823b4724b7f93b50

commit 46a15abd9382ae51aabc3b16823b4724b7f93b50
Author: Marc Treib <treib@chromium.org>
Date: Tue Apr 24 15:10:08 2018

Fix DCHECKs in IdentityManager::GetPrimaryAccountInfo

On ChromeOS, IdentityManager::GetPrimaryAccountInfo DCHECKs that its
view of the primary account info matches the one in SigninManagerBase.
However, if the primary account's refresh token gets revoked, then the
account gets removed from the AccountTrackerService, and
SigninManagerBase will only remember the account's ID, but not the
full AccountInfo.
This CL updates the DCHECKs so that they only verify the account ID in
this case.

Bug:  825190 ,  806775 
Change-Id: I6cbde518e064b590109ef8ca165a1106c7ebda83
Reviewed-on: https://chromium-review.googlesource.com/1025094
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553116}
[modify] https://crrev.com/46a15abd9382ae51aabc3b16823b4724b7f93b50/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/46a15abd9382ae51aabc3b16823b4724b7f93b50/services/identity/public/cpp/identity_manager.cc

Comment 8 by treib@chromium.org, May 8 2018

Blocking: 840703

Comment 9 by treib@chromium.org, Jun 12 2018

Owner: blundell@chromium.org
Status: Started (was: Available)
Colin, can this be considered done after https://crrev.com/c/1076047?
Status: Fixed (was: Started)
Whoops, yes! Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1076047.
Blocking: -808989

Sign in to add a comment