Issue metadata
Sign in to add a comment
|
3.6%-6.4% regression in speedometer2 at 530850:531017 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 29 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12fc5e4a840000
,
Jan 29 2018
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12fc5e4a840000 Use explicit API to request code cache. By mythria@chromium.org ยท Mon Jan 22 17:23:23 2018 chromium @ 76067d1c63e1e6b2ba456059c78532a748f8f41a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 30 2018
I am not sure why there is a regression. That cl shouldn't have changed anything in the overall time. It should just request the code cache explicitly. Earlier it was requested along with compile requests. I will take a look.
,
Jan 30 2018
I looked into this. I still don't see why it regressed. It any what I noticed is a small improvement in the second run (if using the same renderer) since after my change we reuse the code in isolate cache. Earlier, we used to compile if we want to produce cache even if there is a hit in isolate. Again, this improvement is very slight (2-3 ms) and we run it for 10 iterations. So I don't really expect to see any difference.
,
Feb 6 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14922069840000
,
Feb 6 2018
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14922069840000
,
Feb 6 2018
I am looking at it again, the scripts that are cached are the same before and after my cl. I verified that we produce and consume cache for the same set of scripts and nothing has changed there. When looking at the traces for the individual runs I cannot see the regression. I kind of think my cl may not be the actual culprit. I will try to bisect it again to verify this.
,
Feb 6 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16c5afa9840000
,
Feb 6 2018
I also notice that the graphs are recovering. I think it was some timing issue which got fixed. I will wait for the bisect results and wait a couple of more days to check the progress on the bots.
,
Feb 7 2018
๐ Found significant differences after each of 3 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16c5afa9840000 Fix rootScroller when iframe's view is swapped. by bokan@chromium.org chromium @ 3f0b9946f52dc4e146e90e7377974e12a76404b5 Revert "Skip unnecessary invalidation of document level NodeList caches" by adithyas@chromium.org chromium @ e4dc91a1eef20385d060e04760de3641989950e5 [oilpan] Extract visitor from marker by mlippautz@chromium.org chromium @ bf779fc562b95cc6a65b3f5a045f2777f97232af Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 7 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/148950c9840000
,
Feb 7 2018
Triggered another bisect. None of the suspects in earlier bisect look quite strong.
,
Feb 7 2018
It's believable to me that the revert of Adithya's CL (the original CL was intended to improve S2 performance) would regress it.
,
Feb 7 2018
My CL was reverted (and still is). Will check if the graphs recovered once I get my hands on a workstation.
,
Feb 7 2018
#14: +1, the revert of my CL definitely caused a regression, and IIRC there was another issue that was created for a speedometer regression that was caused by it.
,
Feb 7 2018
Thanks adithyas@ and jborman@. I wasn't sure because the original cl landed @527730 and I did not see any performance improvements there. So, I wasn't too sure.
,
Feb 7 2018
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/148950c9840000 Use explicit API to request code cache. by mythria@chromium.org chromium @ 76067d1c63e1e6b2ba456059c78532a748f8f41a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 8 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 29 2018