New issue
Advanced search Search tips

Issue 806759 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Shows an error while installing a sample pass to Passbook

Project Member Reported by subhashi...@chromium.org, Jan 29 2018

Issue description

App Version: 65.0.3325.29 beta
iOS Version: 10.3.3, 11.2.5
Device: iPhone 7 Plus, iPhone 8
URL: https://q.passkit.net/~/#/t/S7CF9W9x

Steps to reproduce:
1. Launch iOS Chrome
2. Navigate to  https://q.passkit.net/~/#/t/S7CF9W9x
3. Enter the details required to create a pass
4. Tap on ‘Get Pass’

Observed results:
Shows an error message ‘Sorry, your Pass cannot be installed to Passbook at this time.’

Expected results:
Should be able to download passkit file successfully to Passbook

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: Yes(Shows a blank page), Safari: No
Bug reproducible on current stable build : M64, No
Bug reproducible on the current beta channel build :M65, Yes

Type-bug-regression? Yes

Link to Image/Video:
https://drive.google.com/open?id=16G5TvQ5SEdFXNchQYAiYqGUB7dT0Oc8z

Behaviour in M64:
https://drive.google.com/open?id=1hKFStkSlE74E5EGeg97vf0-Vi9cW7pl7



 
Cc: mard...@chromium.org
Cc: linds...@chromium.org
Labels: -Type-Bug Type-Bug-Regression

Comment 3 by pkl@chromium.org, Jan 29 2018

Labels: M-65
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Cc: -eugene...@chromium.org
Labels: -Restrict-View-Google ReleaseBlock-Stable
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3955573a047a6b2ec777adab157787876cad3616

commit 3955573a047a6b2ec777adab157787876cad3616
Author: Eugene But <eugenebut@google.com>
Date: Tue Jan 30 16:02:26 2018

Use Chrome User Agent for download requests.

Some web sites return HTML page instead of PassKit object if request's
User Agent is not a known iOS browser.

Bug:  806759 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I566fe85eadb889dd715ddf858b07b6cef4a736c5
Reviewed-on: https://chromium-review.googlesource.com/891760
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532893}
[modify] https://crrev.com/3955573a047a6b2ec777adab157787876cad3616/ios/web/download/download_controller_impl.mm
[modify] https://crrev.com/3955573a047a6b2ec777adab157787876cad3616/ios/web/download/download_inttest.mm
[modify] https://crrev.com/3955573a047a6b2ec777adab157787876cad3616/ios/web/public/test/fakes/test_web_client.h
[modify] https://crrev.com/3955573a047a6b2ec777adab157787876cad3616/ios/web/public/test/fakes/test_web_client.mm

Labels: Merge-Request-65
Status: Fixed (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a503ae55e2d9fa0f06a7571efb61d20027f195eb

commit a503ae55e2d9fa0f06a7571efb61d20027f195eb
Author: Eugene But <eugenebut@google.com>
Date: Wed Jan 31 17:07:25 2018

Use Chrome User Agent for download requests.

Some web sites return HTML page instead of PassKit object if request's
User Agent is not a known iOS browser.

TBR=eugenebut@google.com

(cherry picked from commit 3955573a047a6b2ec777adab157787876cad3616)

Bug:  806759 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I566fe85eadb889dd715ddf858b07b6cef4a736c5
Reviewed-on: https://chromium-review.googlesource.com/891760
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532893}
Reviewed-on: https://chromium-review.googlesource.com/894696
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#200}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/a503ae55e2d9fa0f06a7571efb61d20027f195eb/ios/web/download/download_controller_impl.mm
[modify] https://crrev.com/a503ae55e2d9fa0f06a7571efb61d20027f195eb/ios/web/download/download_inttest.mm
[modify] https://crrev.com/a503ae55e2d9fa0f06a7571efb61d20027f195eb/ios/web/public/test/fakes/test_web_client.h
[modify] https://crrev.com/a503ae55e2d9fa0f06a7571efb61d20027f195eb/ios/web/public/test/fakes/test_web_client.mm

Status: Verified (was: Fixed)
Verified in:

App Version: 65.0.3325.39 beta
Devices: iPhone 7 Plus, iPhone X
iOS Versions: 10.3.3, 11.2.5

Issue is fixed. Error message is not displayed and able to download PassKit file successfully to Passbook from URL https://q.passkit.net/~/#/t/S7CF9W9x

Current Behaviour:
https://drive.google.com/open?id=1f6ZIsXuk6NapM7PJokbKrmw4esc2gYIJ
Labels: -FoundIn-65 found-in-m65

Sign in to add a comment