Dismiss context menu and tap on any url will not redirect to the target page |
|||||
Issue descriptionApp Version: 65.0.3325.29 Beta iOS Version: 10.3.3 and 11.2.5 Device: iPhone and iPad Steps to reproduce: 1. Launch chrome 2. Search for any word (eg: “himalayas”) in omnibox 3. In Google search result page, long press on any of the link 4. Dismiss context menu 5. Tap on any other link Observed results: Notice that tapping on link doesn’t redirect to the target page Note: Tapping on the link for second time, page will redirect to target page Expected results: Tapping on the link should redirect to target page Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: No, Safari: No Bug reproducible on current stable build (App Version, iOS Version): Yes on M64 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M65 Link to video/image: https://drive.google.com/file/d/1l2oHi7VCM4yCb5iQ6VYQaMtSg-r8Zx3V/view?usp=sharing
,
May 25 2018
Mike, can you take a look at this bug?
,
Sep 17
It looks like calling |__gCrWeb.suppressNextClick()| in CRWContextMenuController is causing this problem. If I remove that call, context menu display still seems to work ok even on iOS 10 simulator. Do you recall the exact symptom of not calling this?
,
Sep 17
,
Sep 17
I think __gCrWeb.suppressNextClick() was added to prevent accidental navigations, because web page recognized long press and link click. It is possible that __gCrWeb.suppressNextClick is not needed anymore.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc7b9c6822f296b79bd26587379ee74120211bb6 commit cc7b9c6822f296b79bd26587379ee74120211bb6 Author: Mike Dougherty <michaeldo@chromium.org> Date: Wed Sep 19 17:18:48 2018 Remove supressNextClick JavaScript. Calling supressNextClick is no longer necessary (as of at least iOS 10.0) to prevent navigation in the web view when presenting a context menu. |suppressNextClick| was incorreclty disabling the next touch after a context menu was canceled. TEST=No side effects after showing context menu Bug: 806737 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40bd1e58a41a2fcab9985a436711da626800e718 Reviewed-on: https://chromium-review.googlesource.com/1228501 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592452} [modify] https://crrev.com/cc7b9c6822f296b79bd26587379ee74120211bb6/ios/web/web_state/js/resources/main_frame_context_menu.js [modify] https://crrev.com/cc7b9c6822f296b79bd26587379ee74120211bb6/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Sep 19
,
Sep 25
Verified in: App Version: 71.0.3561.0 canary iOS Versions: 10.3.3, 11.4.1, 12.0 Devices: iPhone 7, iPhone 8 Plus, iPhoneX Tapping on any url on dismissing the context menu redirects to target page. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkl@chromium.org
, Jan 29 2018Components: -UI>Browser>Contextual Mobile>WebView>Glue UI>Browser
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)