Issue metadata
Sign in to add a comment
|
Regression: Focus does not shift to 'Options' button of Translate bubble after clicking on it.
Reported by
db...@etouch.net,
Jan 29 2018
|
||||||||||||||||||||||
Issue description
Chrome Version: 66.0.3334.0 (Official Build) Revisiondec7220f080ea5dc647603e2dd8092afe6bb302f-refs/heads/master@{#532207}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS)
What steps will reproduce the problem?
(1) Launch chrome, navigate to www.sohu.com(Translate bubble appears )
(2) Keep focus on translate button and click on Options button.
(3) Observe focus highlight.
Actual: Focus does not shift to 'Options' button after clicking on it.
Expected: Focus should shift to 'Options' button after clicking on it.
This is a regression issue, broken in 'M65', providing bisect using bisect per revision:
Good Build:65.0.3300.0(Revision: 525557)
Bad Build: 65.0.3302.0(Revision: 526108)
You are probably looking for a change made after 526084(known good), but no later than 526085(first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/f0cc25a44ebf7c606a2e11b73cba1df0a52bdb5e..fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2
Suspect : https://chromium.googlesource.com/chromium/src/+/fe01fb1dde7d765c4178e7a0ba5e8cbbb3c3e1a2
@pbos- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: 1.Issue is not seen on Mac OS X(10.12.6,10.13.1,10.13.3).
2.The above issue is also seen on Dev build #65.0.3325.18
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b2d1d1e3229e3af1d3687c3e9626664623f6166 commit 5b2d1d1e3229e3af1d3687c3e9626664623f6166 Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 31 23:06:42 2018 Move focus to option button in translate bubble. As the options button doesn't make the dialog bubble go away focus needs to be moved to it. Bug: chromium:806729 Change-Id: I78fcdfbf098d0b44b2beec47ec6446b09a89c6c2 Reviewed-on: https://chromium-review.googlesource.com/894858 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533464} [modify] https://crrev.com/5b2d1d1e3229e3af1d3687c3e9626664623f6166/chrome/browser/ui/views/translate/translate_bubble_view.cc
,
Jan 31 2018
Fix above is simple / low risk. Requesting merge (but won't push it in until next week, or N days in Canary / Dev).
,
Feb 1 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aec506d3386e4325ed274c878935dda4f0e72272 commit aec506d3386e4325ed274c878935dda4f0e72272 Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 02 01:05:46 2018 Move focus to option button in translate bubble. As the options button doesn't make the dialog bubble go away focus needs to be moved to it. Bug: chromium:806729 Change-Id: I78fcdfbf098d0b44b2beec47ec6446b09a89c6c2 Reviewed-on: https://chromium-review.googlesource.com/894858 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533464}(cherry picked from commit 5b2d1d1e3229e3af1d3687c3e9626664623f6166) Reviewed-on: https://chromium-review.googlesource.com/898491 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#252} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/aec506d3386e4325ed274c878935dda4f0e72272/chrome/browser/ui/views/translate/translate_bubble_view.cc
,
Feb 2 2018
,
Feb 2 2018
,
Feb 5 2018
Just to Update: Rechecked above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) using latest canary build #66.0.3340.0 and it is fixed. Kindly refer attached video for the reference. Thank you.
,
Feb 6 2018
Just to Update: Rechecked above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) using latest canary build #65.0.3325.51 and it is fixed. Kindly refer attached video for the reference. Thank you.
,
Feb 6 2018
Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Jan 29 2018