Multiple Mac ASan 64 Tests (1) tests fail constantly. |
|||
Issue description
,
Jan 29 2018
Across the tests, the log seems to be the same as well.
,
Jan 29 2018
In the log there are more stacktraces and they mention: - base::FieldTrialList::~FieldTrialList() - base::FieldTrialList::CreateFieldTrial - variations::AssociateParamsFromFieldTrialConfig - variations::VariationsFieldTrialCreator::SetupFieldTrials - variations::VariationsService::SetupFieldTrials - ChromeBrowserMainParts::SetupFieldTrials() - base::FieldTrial::FinalizeGroupChoiceImpl(bool)
,
Jan 29 2018
https://chromium-review.googlesource.com/c/chromium/src/+/880482 touches variations folder and is present in the first failing build (38164). I am reverting the CL.
,
Jan 29 2018
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ffe77a94e69614a56674d46928c1bc3c13e07c commit 92ffe77a94e69614a56674d46928c1bc3c13e07c Author: vitaliii <vitaliii@chromium.org> Date: Mon Jan 29 11:58:50 2018 Revert "[Variations] Avoid duplication of the safe seed value stored in prefs." This reverts commit 4db68ed928f89e9c2f2a835a3988aa9afc44adcf. Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712 ). Original change's description: > [Variations] Avoid duplication of the safe seed value stored in prefs. > > When the safe seed and the latest seed have identical contents, use a sentinel > value to avoid storing a duplicate value for the two seeds. This is purely a > storage space optimization; no difference in observed functionality is expected. > > R=asvitkine@chromium.org > > Bug: 727984 > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb > Reviewed-on: https://chromium-review.googlesource.com/880482 > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532027} TBR=isherman@chromium.org,asvitkine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727984, 806712 Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456 Reviewed-on: https://chromium-review.googlesource.com/891119 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532401} [modify] https://crrev.com/92ffe77a94e69614a56674d46928c1bc3c13e07c/components/variations/variations_seed_store.cc [modify] https://crrev.com/92ffe77a94e69614a56674d46928c1bc3c13e07c/components/variations/variations_seed_store.h [modify] https://crrev.com/92ffe77a94e69614a56674d46928c1bc3c13e07c/components/variations/variations_seed_store_unittest.cc
,
Jan 29 2018
Hm, the builder just did not build anything. I forced a build to check whether the revert fixes the issue. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/38198
,
Jan 29 2018
Might be http://crbug.com/806901 ? "MacMDDownloadShelf" coincides with https://chromium-review.googlesource.com/887385 .
,
Jan 29 2018
The bot is green now, so the revert seems to have worked.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ab886250eefd33d60c646a3360462b3040562d commit 89ab886250eefd33d60c646a3360462b3040562d Author: Ilya Sherman <isherman@chromium.org> Date: Wed Jan 31 00:01:25 2018 Revert "Revert "[Variations] Avoid duplication of the safe seed value stored in prefs."" This reverts commit 92ffe77a94e69614a56674d46928c1bc3c13e07c. Reason for revert: I suspect that the original revert was inappropriate – more detailed reasoning left as a review comment on the revert CL. Original change's description: > Revert "[Variations] Avoid duplication of the safe seed value stored in prefs." > > This reverts commit 4db68ed928f89e9c2f2a835a3988aa9afc44adcf. > > Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712 ). > > Original change's description: > > [Variations] Avoid duplication of the safe seed value stored in prefs. > > > > When the safe seed and the latest seed have identical contents, use a sentinel > > value to avoid storing a duplicate value for the two seeds. This is purely a > > storage space optimization; no difference in observed functionality is expected. > > > > R=asvitkine@chromium.org > > > > Bug: 727984 > > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb > > Reviewed-on: https://chromium-review.googlesource.com/880482 > > Commit-Queue: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532027} > > TBR=isherman@chromium.org,asvitkine@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 727984, 806712 > Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456 > Reviewed-on: https://chromium-review.googlesource.com/891119 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532401} TBR=isherman@chromium.org,asvitkine@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727984, 806712 Change-Id: I1627111dacc8d59bc43aa7b1b7ed76db8f165ee2 Reviewed-on: https://chromium-review.googlesource.com/894622 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533098} [modify] https://crrev.com/89ab886250eefd33d60c646a3360462b3040562d/components/variations/variations_seed_store.cc [modify] https://crrev.com/89ab886250eefd33d60c646a3360462b3040562d/components/variations/variations_seed_store.h [modify] https://crrev.com/89ab886250eefd33d60c646a3360462b3040562d/components/variations/variations_seed_store_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by vitaliii@chromium.org
, Jan 29 2018Across the builds, the failure log seems to be the same. E.g. for WebstoreStartupInstallUnpackFailureTest.WebstoreStartupInstallUnpackFailureTest, the relevant bit is: ==== [ RUN ] WebstoreStartupInstallUnpackFailureTest.WebstoreStartupInstallUnpackFailureTest [46954:56579:0126/132114.637094:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.p9WT2D/d4cwZTg/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [46954:1287:0126/132114.644991:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. [46954:7175:0126/132114.674726:WARNING:app_launch_info.cc(280)] Override URL passed for Web Store should not contain a port. Removing it. [46959:3335:0126/132114.989795:WARNING:vt_video_decode_accelerator_mac.cc(177)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [46959:3335:0126/132114.992697:WARNING:vt_video_decode_accelerator_mac.cc(199)] Failed to create hardware VideoToolbox session [46959:3335:0126/132115.087538:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [46954:56579:0126/132115.100880:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.p9WT2D/d4cwZTg/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [46960:3335:0126/132115.609185:WARNING:app_launch_info.cc(280)] Override URL passed for Web Store should not contain a port. Removing it. [46954:38915:0126/132115.896280:WARNING:simple_synchronous_entry.cc(1217)] Could not open platform files for entry. [46954:20743:0126/132116.064312:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico [46954:36099:0126/132117.105090:ERROR:memory_mapped_file_posix.cc(165)] mmap 101: Invalid argument (22) [46954:39683:0126/132117.122663:WARNING:quarantine_mac.mm(202)] MDItemCreate failed for path /private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.p9WT2D/d4cwZTg/Webstore Downloads/cccccccccccccccccccccccccccccccc_30704.crx [46954:7175:0126/132117.129213:WARNING:load_error_reporter.cc(78)] Extension error: Package is invalid: 'CRX_HEADER_INVALID'. [46954:7175:0126/132117.243913:INFO:chrome_cryptauth_service.cc(231)] Profile is not authenticated yet; waiting before starting CryptAuth managers. [46954:46083:0126/132117.318716:WARNING:discardable_shared_memory_manager.cc(436)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [46954:7175:0126/132117.330982:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. ================================================================= ==46954==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100006f764 at pc 0x00010fccf41c bp 0x7fff5a1a3110 sp 0x7fff5a1a3108 READ of size 4 at 0x61100006f764 thread T0 #0 0x10fccf41b in base::FieldTrial::FinalizeGroupChoiceImpl(bool) ??:0:0 #1 0x10fccd91a in base::FieldTrial::group() ??:0:0 #2 0x10fc262ec in base::FeatureList::IsFeatureEnabled(base::Feature const&) ??:0:0 #3 0x119fa120e in -[DownloadShelfView adjustHeightForDivider] ??:0:0 #4 0x7fff8abeb18f in -[NSView _setWindow:] ??:0:0 #5 0x7fff893142f8 in __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke ??:0:0 #6 0x7fff89313a9e in -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] ??:0:0 #7 0x7fff8b32ec71 in __21-[NSView _setWindow:]_block_invoke712 ??:0:0 #8 0x7fff8abeb15e in -[NSView _setWindow:] ??:0:0 #9 0x7fff893142f8 in __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke ??:0:0 #10 0x7fff89313a9e in -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] ??:0:0 #11 0x7fff8b32ec71 in __21-[NSView _setWindow:]_block_invoke712 ??:0:0 #12 0x7fff8abeb15e in -[NSView _setWindow:] ??:0:0 #13 0x7fff893142f8 in __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke ??:0:0 #14 0x7fff89313a9e in -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] ??:0:0 #15 0x7fff8b32ec71 in __21-[NSView _setWindow:]_block_invoke712 ??:0:0 #16 0x7fff8abeb15e in -[NSView _setWindow:] ??:0:0 #17 0x7fff8abf40ec in -[NSThemeFrame _setWindow:] ??:0:0 #18 0x7fff8ae41ed8 in -[NSWindow dealloc] ??:0:0 #19 0x11a0066eb in -[FramedBrowserWindow dealloc] ??:0:0 #20 0x7fff8abf35e9 in -[NSWindow release] ??:0:0 #21 0x7fff88b23659 in (anonymous namespace)::AutoreleasePoolPage::pop(void*) ??:0:0 #22 0x7fff892ca931 in _CFAutoreleasePoolPop ??:0:0 #23 0x7fff879f2436 in -[NSAutoreleasePool drain] ??:0:0 #24 0x1164f0f49 in service_manager::Main(service_manager::MainParams const&) ??:0:0 #25 0x10fb4ce0f in content::ContentMain(content::ContentMainParams const&) ??:0:0 #26 0x111341fa7 in content::BrowserTestBase::SetUp() ??:0:0 #27 0x10fedadf4 in InProcessBrowserTest::SetUp() ??:0:0 #28 0x10930c64f in testing::Test::Run() ??:0:0 #29 0x10930e8a3 in testing::TestInfo::Run() ??:0:0 #30 0x10930fbe6 in testing::TestCase::Run() ??:0:0 #31 0x109327b96 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0 #32 0x109327129 in testing::UnitTest::Run() ??:0:0 #33 0x10ff2bf08 in base::TestSuite::Run() ??:0:0 #34 0x10fbeff35 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ??:0:0 #35 0x111429363 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ??:0:0 #36 0x10fbf0bb2 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ??:0:0 #37 0x10fbefd8c in main ??:0:0 #38 0x7fff832285fc in start ??:0:0 ====