New issue
Advanced search Search tips

Issue 806706 link

Starred by 1 user
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus doesn't traverse to 'Learn more' (?) icon after pressing tab key.

Reported by vku...@etouch.net, Jan 29 2018 
Chrome Version:66.0.3334.0 (Official Build) Revisiondec7220f080ea5dc647603e2dd8092afe6bb302f-refs/heads/master@{#532207}(32/64-bit) 
OS:Windows (7,8,8.1,10),Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://settings/
(2)Right click on search field > spellcheck > Ask google for suggestions
(3)Press tab key on overlay and observe.

Actual: Focus doesn't traverse to 'Learn more'(?) icon after pressing tab key.

Expected: Focus should traverse to 'Learn more'(?) icon after pressing tab key.

This is a regression issue broken in 'M66' and below is the manual bisect info
Good Build: 66.0.3331.0 (Revision:531795)
Bad Build: 66.0.3332.0  (Revision:531900)

Note: Issue not seen on Mac OS X(10.12.6,10.13.1,10.13.3)
Actual.mp4
417 KB View Download

Comment 1 by vku...@etouch.net, Jan 29 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 531894 (known good), but no later than 531895 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/0fc0e49c81e22c768f9e1d3e8fe55a401425907d..3f6a13da6125b169fb4cc69f58682d9beed3ec80

Suspecting: https://chromium.googlesource.com/chromium/src/+/3f6a13da6125b169fb4cc69f58682d9beed3ec80

@kylixrd: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Refer expected screen-cast for Mac OS.
Expected_Mac OS.mov
1.6 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190a3e4a3b3958abc2df7d22138dac4b2406a867

commit 190a3e4a3b3958abc2df7d22138dac4b2406a867
Author: Allen Bauer <kylixrd@chromium.org>
Date: Mon Jan 29 19:23:03 2018

Made sure "Learn More" button on "Ask Google for suggestions" dialog is able to be focused.

Ensure focusability is enabled along with the correct tool-tip.

Bug:  806706 
Change-Id: Ic60278a2d57f1c23cf36c8633994eb39fc7a5417
Reviewed-on: https://chromium-review.googlesource.com/890388
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532535}
[modify] https://crrev.com/190a3e4a3b3958abc2df7d22138dac4b2406a867/chrome/browser/ui/views/confirm_bubble_views.cc

Comment 3 by kylixrd@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)

Comment 4 by aiman.an...@etouch.net, Jan 31 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3335.0
Update : 
Retested above issue on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS using latest Canary #66.0.3335.0 and issue is fixed. Now, Focus travels on Learn more(?) link after pressing tab key. Kindly review the attached screen-cast.

Thank you!
Current_Result.mp4
766 KB View Download

Comment 5 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported
►

Sign in to add a comment