New issue
Advanced search Search tips

Issue 806694 link

Starred by 1 user
Status: Verified
Owner:
kkhorimoto@chromium.org
Closed: Jan 2018
Cc:
stkhapugin@chromium.org
sczs@chromium.org
gambard@chromium.org
kkhorimoto@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Omnibox is not displayed on relaunch of app which is running in background

Project Member Reported by rakurati@chromium.org, Jan 29 2018 
App Version:65.0.3325.16 Beta
iOS Version:  10.3.3 and 11.2.5 beta 7
Device: iPad and iPhone

Steps to reproduce:
1. Launch chrome
2. Load nytimes.com and scroll to full screen
3. Background the app and relaunch the chrome

Observed results:
Notice that the omnibox is not displayed

Expected results:
Omnibox should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No on M64
Bug reproducible on the current beta channel build (App Version, iOS Version):yes on M65 Beta

Link to video/image:
https://drive.google.com/file/d/16jSxczRlVdKsrlZzVmF3949I10lG0OQG/view?usp=sharing

Comment 1 by pkl@chromium.org, Jan 29 2018

Cc: gambard@chromium.org kkhorimoto@chromium.org
Labels: M-65
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
This may be a duplicate,  but not 100% sure.
This may be Omnibox, but can also be Toolbar or Fullscreen.

Comment 2 by gambard@chromium.org, Jan 30 2018

Cc: sczs@chromium.org stkhapugin@chromium.org
Labels: Bijou-Fullscreen
Owner: kkhorimoto@chromium.org
I think this is a fullscreen bug. Assigning to kkhorimoto@. Please assess if RBS for new fullscreen.

Comment 3 by kkhorimoto@chromium.org, Jan 30 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea0da20924b035b0188ad7ea9ef7a9af85720f26

commit ea0da20924b035b0188ad7ea9ef7a9af85720f26
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jan 31 04:14:27 2018

[iOS] Show toolbar when app is foregrounded.

This CL adds a new animator, FullscreenForegroundAnimator that is sent
to FullscreenControllerObservers upon receipt of an application
foreground notification.  This CL also updates FullscreenUIElements
to show the toolbar using this animator.

Bug:  806694 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9470602d5535964ea0a054c949ccaba0225e5ed3
Reviewed-on: https://chromium-review.googlesource.com/894355
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533198}
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.h
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_controller_observer.h
[add] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_foreground_animator.h
[add] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_foreground_animator.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.h
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm
[add] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.h
[add] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_ui_element.h
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater.h
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater_unittest.mm
[delete] https://crrev.com/c6a29b98fa8da4098539d3a9a9dbc498552ea041/ios/chrome/browser/ui/fullscreen/system_notification_fullscreen_disabler.h
[delete] https://crrev.com/c6a29b98fa8da4098539d3a9a9dbc498552ea041/ios/chrome/browser/ui/fullscreen/system_notification_fullscreen_disabler.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
[modify] https://crrev.com/ea0da20924b035b0188ad7ea9ef7a9af85720f26/ios/chrome/browser/ui/toolbar/toolbar_controller.mm

Comment 6 by kkhorimoto@chromium.org, Jan 31 2018

Labels: Merge-Request-65
Status: Fixed (was: Started)
Requesting merge for M65, but not sure if this is worth the risk.  This CL is built upon some code that was landed to fix Issue 796946, so they would both need to be merged together.  It's still early in the branch, so this seems feasible, but the fixes for each of these bugs touches quite a few files.

Comment 7 by cma...@chromium.org, Feb 1 2018

Labels: -Merge-Request-65 Merge-Approved-65

Comment 8 by srikanthg@chromium.org, Feb 5 2018

Status: Verified (was: Fixed)
Verified in M66.0.3340.0 Canary
Device: iPhoneX, iPhone7plus, iPad Pro
iOS: 11.3, 11.1.2, 11.2.5

Omnibox is displayed correctly after launching the app from background.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaa7692e7c3a6f233ad8e4920dbb80062de289f5

commit eaa7692e7c3a6f233ad8e4920dbb80062de289f5
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Feb 06 03:09:02 2018

[iOS] Show toolbar when app is foregrounded.

This CL adds a new animator, FullscreenForegroundAnimator that is sent
to FullscreenControllerObservers upon receipt of an application
foreground notification.  This CL also updates FullscreenUIElements
to show the toolbar using this animator.

TBR=kkhorimoto@chromium.org

(cherry picked from commit ea0da20924b035b0188ad7ea9ef7a9af85720f26)

Bug:  806694 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9470602d5535964ea0a054c949ccaba0225e5ed3
Reviewed-on: https://chromium-review.googlesource.com/894355
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533198}
Reviewed-on: https://chromium-review.googlesource.com/903420
Cr-Commit-Position: refs/branch-heads/3325@{#341}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.h
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_controller_observer.h
[add] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_foreground_animator.h
[add] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_foreground_animator.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.h
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm
[add] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.h
[add] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_ui_element.h
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater.h
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater_unittest.mm
[delete] https://crrev.com/7483f3eb61d702d1d557d1a291f81c38491acb4d/ios/chrome/browser/ui/fullscreen/system_notification_fullscreen_disabler.h
[delete] https://crrev.com/7483f3eb61d702d1d557d1a291f81c38491acb4d/ios/chrome/browser/ui/fullscreen/system_notification_fullscreen_disabler.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
[modify] https://crrev.com/eaa7692e7c3a6f233ad8e4920dbb80062de289f5/ios/chrome/browser/ui/toolbar/toolbar_controller.mm

Comment 10 by pmadalla@chromium.org, Feb 14 2018 

Verified the issue on 65.0.3325.70 tested on iPhone7+(iOS 11)
Omnibox is displayed on relaunching chrome in full screen mode.
►

Sign in to add a comment