The previous sheriff has reverted https://chromium-review.googlesource.com/c/chromium/src/+/887250 in crrev.com/c/890841.

However, the last unfinished build with the revert (https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25912) shows that the test still fails.

The test started to crash in https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25872, but there was another brief period of crashes before from https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25818 to https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25822.

The brief period log is different from the latest failures log - the stack trace is very different (see files attached).

The relevant bit from the latest failures:

=====
==579==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f0f8a754a88 at pc 0x00000061e329 bp 0x7ffc88dc7e60 sp 0x7ffc88dc7610
READ of size 56 at 0x7f0f8a754a88 thread T0
    #0 0x61e328 in __asan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:23:3
    #1 0x75518d1 in GestureEvent ui/events/event.cc:1486:53
    #2 0x75518d1 in make_unique<ui::GestureEvent, const ui::GestureEvent &> buildtools/third_party/libc++/trunk/include/memory:3026
    #3 0x75518d1 in ui::Event::Clone(ui::Event const&) ui/events/event.cc:226
    #4 0x7568303 in ui::EventProcessor::OnEventFromSource(ui::Event*) ui/events/event_processor.cc:26:18
    #5 0x7569b42 in DeliverEventToSink ui/events/event_source.cc:73:16
    #6 0x7569b42 in ui::EventSource::SendEventToSink(ui::Event*) ui/events/event_source.cc:51
    #7 0x78c2486 in views::NativeWidgetAura::OnGestureEvent(ui::GestureEvent*) ui/views/widget/native_widget_aura.cc:920:14
    #8 0x75646e1 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #9 0x75646e1 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139
    #10 0x75640b8 in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14
    #11 0x75640b8 in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58
    #12 0x756878e in ui::EventProcessor::OnEventFromSource(ui::Event*) ui/events/event_processor.cc:57:17
    #13 0x7569b42 in DeliverEventToSink ui/events/event_source.cc:73:16
    #14 0x7569b42 in ui::EventSource::SendEventToSink(ui::Event*) ui/events/event_source.cc:51
    #15 0x75c40de in ui::test::EventGenerator::DoDispatchEvent(ui::Event*, bool) ui/events/test/event_generator.cc:736:29
    #16 0x70deee in ash::AppListPresenterDelegateTest_UnhandledEventOnPeeking_Test::TestBody() ash/app_list/app_list_presenter_delegate_unittest.cc:780:15
    #17 0x301861c in testing::Test::Run() third_party/googletest/src/googletest/src/gtest-internal-inl.h
    #18 0x301a2f4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2651:11
    #19 0x301b656 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2769:28
    #20 0x3031326 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4665:43
    #21 0x3030868 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #22 0x560632b in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2233:46
    #23 0x560632b in base::TestSuite::Run() base/test/test_suite.cc:272
    #24 0x560bba8 in Run base/callback.h:94:12
    #25 0x560bba8 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::RepeatingCallback<int ()> const&, unsigned long, int, bool, base::RepeatingCallback<void ()> const&) base/test/launcher/unit_test_launcher.cc:220
    #26 0x560b6a0 in base::LaunchUnitTests(int, char**, base::RepeatingCallback<int ()> const&) base/test/launcher/unit_test_launcher.cc:558:10
    #27 0x12c598c in main ash/test/ash_unittests.cc:14:10
    #28 0x7f0f8e6e0f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287
=====

Deleted: brief_period_log.txt 13.8 KB

brief_period_log.txt 13.8 KB View Download

Deleted: latest_logs.txt 6.3 KB

latest_logs.txt 6.3 KB View Download

This test also fails in ash_unittests, thus, I am adding them to this bug. The log is the same.

The failure log in the latest unfinished build with the revert is the same.

The test has been touched in https://chromium-review.googlesource.com/c/chromium/src/+/887282 and this CL belongs to the first build (https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25872), where the test started to fail.

The CL adds the line which fails, moreover, FindIt identified the CL as a culprit long time ago:

https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNkM2E1MjY3ODQ2OTMxNjJmNjI5ODU2NDIxMWZhYmEwMmZkMzAxZWQM

I am reverting the CL.

The revert is https://chromium-review.googlesource.com/c/chromium/src/+/890264.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04d987a13a187ab7d06cbe033fec9ab4762c2ad0

commit 04d987a13a187ab7d06cbe033fec9ab4762c2ad0
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jan 29 09:57:51 2018

Revert "cros: Don't dismiss AppList on right click/two finger tap"

This reverts commit 3d3a526784693162f6298564211faba02fd301ed.

Reason for revert: Causes UnhandledEventOnPeeking to fail constantly (see  crbug.com/806690 ).

Original change's description:
> cros: Don't dismiss AppList on right click/two finger tap
> 
> UX request:
> - Don't dismiss AppList if the right click/two finger tap
>   is on the shield of the AppList.
> 
> - Added a test.
> 
> Bug: 805937
> Change-Id: Id38b5872c3836680d08adbcb84922fe62201be19
> Reviewed-on: https://chromium-review.googlesource.com/887282
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532023}

TBR=jennyz@chromium.org,newcomer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 805937,  806690 
Change-Id: I4acd4bbea8a85988224efa7573b719655628e445
Reviewed-on: https://chromium-review.googlesource.com/890264
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532374}
[modify] https://crrev.com/04d987a13a187ab7d06cbe033fec9ab4762c2ad0/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/04d987a13a187ab7d06cbe033fec9ab4762c2ad0/ui/app_list/views/app_list_view.cc

The builder is green now.

 Issue 806638  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116c88e09a73998d86329815cda8fd4b2419b08a

commit 116c88e09a73998d86329815cda8fd4b2419b08a
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Jan 31 20:55:23 2018

Reland:cros: Don't dismiss AppList on right click/two finger tap

Created a GestureEvent instead of a TouchEvent. The issue was
that the TouchEvent was being casted as a GestureEvent later on,
but it was not allocated properly.

Bug:  806690 
Change-Id: Id9b3491e93a3fd5a4f3c2185b7a0727b43f309e3
Reviewed-on: https://chromium-review.googlesource.com/892094
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533401}
[modify] https://crrev.com/116c88e09a73998d86329815cda8fd4b2419b08a/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/116c88e09a73998d86329815cda8fd4b2419b08a/ui/app_list/views/app_list_view.cc