Issue metadata
Sign in to add a comment
|
chromite/cbuildbot: risk report code failing on AttributeError when chromiumos-cl-scanner.appspot.com returns an error
Reported by
vpalatin@chromium.org,
Jan 29 2018
|
||||||||||||||||||||||||
Issue descriptionThe CQ run got a 502 error on https://chromiumos-cl-scanner.appspot.com/external/risk/build/2250292 (see issue 806687 ) but then the report_stages cbuilbot python code died on : File "/b/c/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 701, in Run self.PerformStage() File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 1050, in PerformStage self._RunRiskReport() File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 1070, in _RunRiskReport for link_text, url in sorted(report.iteritems()): AttributeError: 'str' object has no attribute 'iteritems' As logged in : https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F17607%2F%2B%2Frecipes%2Fsteps%2FReport%2F0%2Fstdout This is likely the previous exception trickling down, but we can probably make this code more robust by checking whether GetCLRiskReport() has returned an error string rather than the result dictionary.
,
Jan 29 2018
The subsequent CQ runs seem to fail on this too (I might misinterpret the root cause of the failure but they definitely have this error) https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/17609 Other URLs from return 502, e.g. https://chromiumos-cl-scanner.appspot.com/external/risk/build/2250771
,
Jan 29 2018
,
Jan 29 2018
Not a Pri-0, because it doesn't actually stop the CQ.
,
Jan 30 2018
I have hard time understanding how the small error in the cbuildbot python script is anyhow a duplicate of the chromiumos-cl-scanner sending 502 errors permanently (else I wouldn't have filed 2 separate issues in first)
,
Jan 31 2018
Ah, you're right. I misinterpreted your first comment to be about the ReportStage failure. Also, the 502s have been fixed - the appengine instance was configured with too little ram and was restarting frequently. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vpalatin@chromium.org
, Jan 29 2018