New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806688 link

Starred by 1 user

Issue metadata

Status: Verified
Merged: issue 806529
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite/cbuildbot: risk report code failing on AttributeError when chromiumos-cl-scanner.appspot.com returns an error

Reported by vpalatin@chromium.org, Jan 29 2018

Issue description

The CQ run got a 502 error on https://chromiumos-cl-scanner.appspot.com/external/risk/build/2250292
(see  issue 806687 )
but then the report_stages cbuilbot python code died on :
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 701, in Run
    self.PerformStage()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 1050, in PerformStage
    self._RunRiskReport()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 1070, in _RunRiskReport
    for link_text, url in sorted(report.iteritems()):
AttributeError: 'str' object has no attribute 'iteritems'

As logged in :
https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F17607%2F%2B%2Frecipes%2Fsteps%2FReport%2F0%2Fstdout

This is likely the previous exception trickling down, but we can probably make this code more robust by checking whether GetCLRiskReport() has returned an error string rather than the result dictionary.
 
Components: -Infra>Platform>Buildbot Infra>Client>ChromeOS
Labels: -Pri-2 Pri-0
The subsequent CQ runs seem to fail on this too
(I might misinterpret the root cause of the failure but they definitely have this error)
https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/17609

Other URLs from return 502, e.g. 
https://chromiumos-cl-scanner.appspot.com/external/risk/build/2250771

Comment 3 by pho...@chromium.org, Jan 29 2018

Labels: -Pri-0 Pri-2
Mergedinto: 806529
Status: Duplicate (was: Untriaged)

Comment 4 by pho...@chromium.org, Jan 29 2018

Not a Pri-0, because it doesn't actually stop the CQ.
I have hard time understanding how the small error in the cbuildbot python script is anyhow a duplicate of the chromiumos-cl-scanner sending 502 errors permanently (else I wouldn't have filed 2 separate issues in first)

Comment 6 by pho...@chromium.org, Jan 31 2018

Status: Verified (was: Duplicate)
Ah, you're right. I misinterpreted your first comment to be about the ReportStage failure.

Also, the 502s have been fixed - the appengine instance was configured with too little ram and was restarting frequently.

Sign in to add a comment