ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked in browser_tests failing on chromium.win/Win7 (32) Tests |
|||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of vitaliii@google.com ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked in browser_tests failing on chromium.win/Win7 (32) Tests Builders failed on: - Win7 (32) Tests: https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
,
Jan 29 2018
The test has been failing since https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/29446 (the only exception is #29450).
,
Jan 29 2018
The first failing build contains only one CL https://chromium-review.googlesource.com/884401 The previous sheriff is reverting it https://chromium-review.googlesource.com/c/chromium/src/+/890978.
,
Jan 29 2018
The log is not very helpful: ====== [ RUN ] ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked [5912:3072:0128/200043.341:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir612_5635\results612_12948\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iouqhaiu\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir612_5635\d612_29876" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [5912:4680:0128/200043.549:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico [5912:3072:0128/200043.686:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200043.738:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200043.744:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200044.313:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200046.316:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200047.323:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [5912:3072:0128/200048.484:WARNING:render_frame_host_impl.cc(2754)] OnDidStopLoading was called twice. [532/846] ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked (TIMED OUT) ======
,
Jan 29 2018
Actually the test was timing out flakily with low frequency (4/19) since https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/29427. The CL above just changed the frequency to ~100%.
,
Jan 29 2018
Both the previous sheriff and I speculate that https://chromium-review.googlesource.com/c/chromium/src/+/889846 may be related to the first failed build (it is from https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/29423, which is green, but soon in 29427 the test fails for the first time).
,
Jan 29 2018
Let's see how the revert from #3 affects to build.
,
Jan 29 2018
The revert did not help. The next two builds (29468 and 29469) are still red.
,
Jan 29 2018
,
Jan 29 2018
Adding OWNERS in case they know more.
,
Jan 29 2018
Devlin is more appropriate...
,
Jan 29 2018
,
Jan 29 2018
Unfortunately, I cannot find the CL which causes this, thus, I am disabling the test.
,
Jan 29 2018
The CL disabling the test is https://chromium-review.googlesource.com/c/chromium/src/+/891022.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d3e4e6f5e91361f76ba2fc67c956d729cb0bae commit 20d3e4e6f5e91361f76ba2fc67c956d729cb0bae Author: vitaliii <vitaliii@chromium.org> Date: Mon Jan 29 12:45:14 2018 Disable ProcessManagerBT.NestedURLNavigationsToExtensionBlocked on Win. Disable ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked because it timeouts constantly on Win. TBR=rdevlin.cronin@chromium.org Bug: 806684 Change-Id: Ic86b6219db299489ec6392b2fd2fe885904bb3d9 Reviewed-on: https://chromium-review.googlesource.com/891022 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532407} [modify] https://crrev.com/20d3e4e6f5e91361f76ba2fc67c956d729cb0bae/chrome/browser/extensions/process_manager_browsertest.cc
,
Jan 29 2018
rdevlin.cronin@, please have a look and reenable or redirect. Thank you!
,
Jan 29 2018
,
Feb 6 2018
@rdevlin.cronin@ can you PTAL since this reduces test coverage?
,
Feb 6 2018
,
Feb 8 2018
This test is failing on Linux trunk of official.desktop.continuous builder as well. Link to the builder: ==================== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/7690 Link to the log: =============== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_trunk%2F7690%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Error log: ========= [8329/8329] ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked (TIMED OUT) 1 test timed out: ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked (../../chrome/browser/extensions/process_manager_browsertest.cc:746) <Thread(Thread-1, started 140122166167296)> ProcessRead: proc.stdout finished. <Thread(Thread-1, started 140122166167296)> ProcessRead: cleaning up. <Thread(Thread-2, started daemon 140122157774592)> TimedFlush: Finished <Thread(Thread-1, started 140122166167296)> ProcessRead: finished. Stopping Xvfb with pid 35846 ...
,
Feb 8 2018
Over to Alex, who added the test. The test is pretty long, and doing a lot of things... if it's only timing out so far (rather than failing) the first step might just be to break it into 2+ separate tests.
,
Feb 14 2018
Just to update: ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked This test is still failing on linux 64 trunk build of official.desktop.continuous builder. Link to the builder: ==================== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/7848 Link to the log: =============== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_trunk%2F7848%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Updating this issue for tracking purpose. Thanks..!
,
Feb 20 2018
Seems like this is flaking on Mac as well (example: https://chromium-swarm.appspot.com/task?id=3bccddb48133f810&refresh=10&show_raw=1)
,
Feb 20 2018
Issue 813527 has been merged into this issue.
,
Feb 20 2018
Flaking on Mac (See the issue above): ``` Detected 11 new flakes for test/step "ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBQcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0Lk5lc3RlZFVSTE5hdmlnYXRpb25zVG9FeHRlbnNpb25CbG9ja2VkDA. This message was posted automatically by the chromium-try-flakes app. ```
,
Feb 21 2018
Just to update: ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked This test is still failing on linux 64 trunk build of official.desktop.continuous builder. Link to the builder: ==================== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/8015 Link to the log: =============== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_trunk%2F8015%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Updating this issue for tracking purpose. Thanks..!
,
Feb 21 2018
Detected 16 new flakes for test/step "ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBQcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0Lk5lc3RlZFVSTE5hdmlnYXRpb25zVG9FeHRlbnNpb25CbG9ja2VkDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 21 2018
Disabling the test for Mac and Linux on https://chromium-review.googlesource.com/c/chromium/src/+/929341.
,
Feb 21 2018
alexmos@ can you PTAL since this reduces test coverage?
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bdf9c8041e83302f352ce42ee58e03f8e6347c4 commit 1bdf9c8041e83302f352ce42ee58e03f8e6347c4 Author: Chong Zhang <chongz@chromium.org> Date: Wed Feb 21 19:08:48 2018 Disable ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked on Mac and Linux Mac Failure: ``` [69222:57347:0220/224433.651772:WARNING:quarantine_mac.mm(202)] MDItemCreate failed for path /Users/chrome-bot/Downloads/da9539bf-5570-4272-a869-7d337c531dde.html [69222:771:0220/224433.729354:WARNING:render_frame_host_impl.cc(2706)] OnDidStopLoading was called twice. 2018-02-20 22:44:33.816 browser_tests[69222:1403] Metadata.framework [Error]: couldn't get the client port BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x00000001104a3b4c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x0000000110d32dd5 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fff890685aa _sigtramp + 26 3 ??? 0x0000000100000000 0x0 + 4294967296 4 CoreFoundation 0x00007fff8b6d3f15 __CFRunLoopServiceMachPort + 181 5 CoreFoundation 0x00007fff8b6d3539 __CFRunLoopRun + 1161 6 CoreFoundation 0x00007fff8b6d2e75 CFRunLoopRunSpecific + 309 7 HIToolbox 0x00007fff86799a0d RunCurrentEventLoopInMode + 226 8 HIToolbox 0x00007fff867997b7 ReceiveNextEventCommon + 479 9 HIToolbox 0x00007fff867995bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 10 AppKit 0x00007fff8b91024e _DPSNextEvent + 1434 11 AppKit 0x00007fff8b90f89b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 12 browser_tests 0x000000011066b580 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x00000001104cb2fa base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x000000011066b4c4 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 15 AppKit 0x00007fff8b90399c -[NSApplication run] + 553 16 browser_tests 0x00000001104e881c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 17 browser_tests 0x00000001104e6a7e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 18 browser_tests 0x00000001104e3279 base::MessageLoop::Run(bool) + 169 19 browser_tests 0x0000000110521499 base::RunLoop::Run() + 249 20 browser_tests 0x0000000110d91377 content::RunMessageLoop() + 87 21 browser_tests 0x0000000110d41e2a content::DownloadTestObserver::WaitForFinished() + 42 22 browser_tests 0x000000010cfbc2c6 extensions::ProcessManagerBrowserTest_NestedURLNavigationsToExtensionBlocked_Test::RunTestOnMainThread() + 15270 23 browser_tests 0x0000000110d32ac0 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 400 24 browser_tests 0x0000000110671677 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4775 25 browser_tests 0x00000001106702ce ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 26 browser_tests 0x000000010e6315c3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 27 browser_tests 0x000000010eb75f25 content::StartupTaskRunner::RunAllTasksNow() + 117 28 browser_tests 0x000000010e62fdbd content::BrowserMainLoop::CreateStartupTasks() + 765 29 browser_tests 0x000000010e6343f3 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 99 30 browser_tests 0x000000010e62db12 content::BrowserMain(content::MainFunctionParams const&) + 210 31 browser_tests 0x000000011039c504 content::ContentMainRunnerImpl::Run() + 564 32 browser_tests 0x0000000112b8950b service_manager::Main(service_manager::MainParams const&) + 2475 33 browser_tests 0x000000011039b8a4 content::ContentMain(content::ContentMainParams const&) + 68 34 browser_tests 0x0000000110d32703 content::BrowserTestBase::SetUp() + 3203 35 browser_tests 0x00000001105c64da InProcessBrowserTest::SetUp() + 506 36 browser_tests 0x000000010d599fa1 testing::Test::Run() + 97 37 browser_tests 0x000000010d59ac40 testing::TestInfo::Run() + 288 38 browser_tests 0x000000010d59b267 testing::TestCase::Run() + 263 39 browser_tests 0x000000010d5a3797 testing::internal::UnitTestImpl::RunAllTests() + 903 40 browser_tests 0x000000010d5a33e3 testing::UnitTest::Run() + 163 41 browser_tests 0x00000001105e8e17 base::TestSuite::Run() + 167 42 browser_tests 0x0000000110489ef5 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 43 browser_tests 0x0000000110d8c3dd content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 477 44 browser_tests 0x000000011048a40c LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 348 45 browser_tests 0x0000000110489e4e main + 94 46 libdyld.dylib 0x00007fff926fc5fd start + 1 ``` TBR=alexmos@chromium.org,rdevlin.cronin@chromium.org Bug: 806684 Change-Id: Idbd5b7485ef29ced93281e517572aefc0baf088f Reviewed-on: https://chromium-review.googlesource.com/929341 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538179} [modify] https://crrev.com/1bdf9c8041e83302f352ce42ee58e03f8e6347c4/chrome/browser/extensions/process_manager_browsertest.cc
,
Feb 21 2018
Removing Sheriff-Chromium since the test has been disabled.
,
Feb 22 2018
I'm OOO for the rest of the week, but I'll try to take a look next week when I'm back.
,
Feb 22 2018
Detected 15 new flakes for test/step "ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBQcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0Lk5lc3RlZFVSTE5hdmlnYXRpb25zVG9FeHRlbnNpb25CbG9ja2VkDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 22 2018
Tentatively removing from sheriff queue again; the most recent detected flakes appear to have been in builds from roughly an hour before the test was disabled.
,
Mar 1 2018
@alexmos can you ptal as this disable reduces test coverage?
,
Mar 1 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b213e00abdebe5b109fc4a1442ecc400b65043f7 commit b213e00abdebe5b109fc4a1442ecc400b65043f7 Author: Alex Moshchuk <alexmos@chromium.org> Date: Fri Mar 09 18:34:24 2018 Break up NestedURLNavigationsToExtensionBlocked into two tests. The test recently starting timing out on the bots, most likely because it was taking too long. It might've become too slow after r529904 added more code to it (coverage for downloads). This CL breaks up the latter addition into its own test. Bug: 806684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183 Reviewed-on: https://chromium-review.googlesource.com/944570 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542177} [modify] https://crrev.com/b213e00abdebe5b109fc4a1442ecc400b65043f7/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/b213e00abdebe5b109fc4a1442ecc400b65043f7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/412a0d5d2ad581d11d91a6dcc7c1cf850761bcc3 commit 412a0d5d2ad581d11d91a6dcc7c1cf850761bcc3 Author: Trent Apted <tapted@chromium.org> Date: Mon Mar 12 01:09:37 2018 Revert "Break up NestedURLNavigationsToExtensionBlocked into two tests." This reverts commit b213e00abdebe5b109fc4a1442ecc400b65043f7. Reason for revert: ProcessManagerBrowserTest.NestedURLDownloadsToExtensionAllowed fails on Win7 (32) since https://ci.chromium.org/buildbot/chromium.win/Win7%20%2832%29%20Tests/31089 errors like [2768:3776:0309/113129.955:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [2768:7568:0309/113130.435:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico Original change's description: > Break up NestedURLNavigationsToExtensionBlocked into two tests. > > The test recently starting timing out on the bots, most likely because > it was taking too long. It might've become too slow after r529904 added > more code to it (coverage for downloads). > > This CL breaks up the latter addition into its own test. > > Bug: 806684 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183 > Reviewed-on: https://chromium-review.googlesource.com/944570 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542177} TBR=rdevlin.cronin@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806684 Change-Id: I75d971eb328af97f4f4aa98efb36628993ce9c96 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/958661 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542414} [modify] https://crrev.com/412a0d5d2ad581d11d91a6dcc7c1cf850761bcc3/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/412a0d5d2ad581d11d91a6dcc7c1cf850761bcc3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Mar 20 2018
@alexmos did you see this revert?
,
Mar 20 2018
Haven't had a chance to take a look at what failed in #38 yet, but it's on my plate.
,
Apr 3 2018
Just to update latest behavior of this bug, still failure is observed on linux64 stable for official.desktop.continuous. Link to the build: ------------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20stable/builds/888 Link to log: ------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_stable%2F888%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Thanks!
,
Apr 11 2018
Just to update latest behavior of this bug: Still failure is observed on win64 stable and linux64 stable for official.desktop.continuous. Stable 64: --------- Link to the build: ----------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20stable/builds/817 Link to the log: --------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_stable%2F817%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout# Linux 64: -------- Link to the build: -------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20stable/builds/904 Link to the log: ------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_stable%2F904%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout alexmos@,Please take a look into it. Thanks..!
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2a81fe2539b07d83843f25b547716c1ec593b50 commit d2a81fe2539b07d83843f25b547716c1ec593b50 Author: Alex Moshchuk <alexmos@chromium.org> Date: Mon May 07 17:35:44 2018 Reland: Break up NestedURLNavigationsToExtensionBlocked into two tests. The test recently starting timing out on the bots, most likely because it was taking too long. It might've become too slow after r529904 added more code to it (coverage for downloads). This CL breaks up the latter addition into its own test. This is a reland of https://chromium-review.googlesource.com/944570, with the difference that it will keep the second test, NestedURLDownloadsToExtensionAllowed, disabled as it was still hitting issues on some bots. Bug: 806684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I595e7926d5eacf239607f2c31aa4ace55730ab92 Reviewed-on: https://chromium-review.googlesource.com/1041280 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#556486} [modify] https://crrev.com/d2a81fe2539b07d83843f25b547716c1ec593b50/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/d2a81fe2539b07d83843f25b547716c1ec593b50/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by vitaliii@chromium.org
, Jan 29 2018