New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806678 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Focus Ring for 'Next' button text is seen exceeding in 'Sync settings' screen

Project Member Reported by mmanchala@chromium.org, Jan 29 2018

Issue description

Chrome Version:  65.0.3325.25/10323.7.0 dev-channel Daisy and Kip
OS: Chrome

What steps will reproduce the problem?
1)Recover Build -> In Sign-in Screen Enter valid Email and Password -> Now click on 'Next' button
(2)Sync settings screen is seen -> In that screen observe blue Focus ring on 'Next' button
(Please refer Video and Screenshot)

Expected: Blue Focus Ring should be around 'Next' button Text i.e. focus should not exceed the text
Actual: Instead Focus Ring for 'Next' button text is exceeding

This is Non-regression Issue as 'Sync settings' screen is seen from 65.0.3311.0

@wzang : Please confirm the issue
 
Actual_FocusRingOnNextButton.mp4
16.9 MB Download
Actual_FocusRingOnNextButton.jpg
316 KB View Download
Expected_FocusRing.jpg
683 KB View Download
Labels: Inhouse-HYD-Reported
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5f88000d518a9dd8a13825ca93c08d6802a032

commit 6c5f88000d518a9dd8a13825ca93c08d6802a032
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Feb 28 02:13:16 2018

cros: Add padding to sync consent next button

Add a 6px padding consistent with other screens such as EULA and
OOBE welcome.

Bug:  806678 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2ddeaf1b576e484a3ddbf6741d326d8fd88a84dc
Reviewed-on: https://chromium-review.googlesource.com/939718
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539657}
[modify] https://crrev.com/6c5f88000d518a9dd8a13825ca93c08d6802a032/chrome/browser/resources/chromeos/login/sync_consent.css

Comment 3 by wzang@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment