New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806670 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression

Blocked on:
issue 800266



Sign in to add a comment

Omnibox alignment misplaces on scrolling down the content suggestion in NTP

Project Member Reported by pmadalla@chromium.org, Jan 29 2018

Issue description

App Version: 65.0.3325.29 Beta
iOS Version: 11.2.2
Device : iPhone X

Steps to reproduce:
  1.  Launch chrome canary.
  2. Load few content suggestions in NTP.
  3. Scroll the content suggestions upwards.
  4. Tap on omnibox.
  5. Scroll down the content suggestions downwards.


Observed results:
Omnibox is misaligned for few seconds.

Expected results:
Omnibox should be in fixed position.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version):   No in M64
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M65

Link to Video :
https://drive.google.com/file/d/1iALvotj05iBdOG2ltqHOD0fEd9COpREn/view?usp=sharing

 

Comment 1 by pkl@chromium.org, Jan 29 2018

Cc: gambard@chromium.org
Components: UI>Browser>Omnibox
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
This is probably more Omnibox than content suggestions. 
Does this happen on non-iPhoneX as well?
Cc: sczs@chromium.org
Labels: clean-toolbar
Owner: gambard@chromium.org
This is actually linked to the clean toolbar. Disabling it fixes the bug.
Cc: justincohen@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>Toolbar
Labels: -Hotlist-iPhoneX
This is because the animations when contracting the omnibox are starting, and the header view is also updated with the animations, so it takes the animation time to be where it should be.
Just starting then stopping the animations for the contraction as we do in the expand part doesn't work, some ContentSuggestions cells are redrawn on top of other, creating a broken effect.

A possible fix would be to use some orchestrator pattern and have two different code path: the animated code path where the event are put inside the animators and the non-animated code path where the changes are directly called without having animators.

I don't have time to do it now as in implies to rewrite most of the animations.
sczs@, justincohen@: Do you think it should be prioritized?
I don't think we should rewrite most of the animations right now.  Perhaps after refresh?

Comment 5 by sczs@chromium.org, Jan 30 2018

Just to be clear we need to change the way how animations are handled right? Not rewrite the actual animation code.

Something like this CL could work as a workaround, maybe? https://chromium-review.googlesource.com/c/chromium/src/+/818489 In any case I don't think fixing this is high priority. 

But eventually I agree with gambard@ and we should have some sort of Orchestrator that help us deal with animations timing. 

Comment 6 by zea@chromium.org, Jan 30 2018

Labels: zine-triaged
Blockedon: 800266
Labels: -clean-toolbar
Owner: ----
Status: Available (was: Assigned)
It is broader than the CL you linked as all the elements currently added to the animator should occur, just not in an animation block.

It is indeed how the animations are handled, there is no problem with the animations.

I am marking this bug available as I don't plan to fix it. For the Adaptive Toolbar I will give the Orchestrator a try and see if it is solving the problem.
Labels: Needs-Feedback
I can't reproduce this post refresh, is this still an issue?
Cc: pmadalla@chromium.org srikanthg@chromium.org
Is someone able to reproduce?

Sign in to add a comment