New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806669 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[bvt-inline] browserBridge.isSandboxedForTesting() Failure on tricky/lumpy/peach_pit-chrome-pfq

Project Member Reported by yoshiki@chromium.org, Jan 29 2018

Issue description

security_SandboxStatus is failing on the recent builds of {tricky,lumpy,peach_pit}-chrome-pfq

Log says:
Failed to evaluate in chrome://gpu "browserBridge.isSandboxedForTesting();"

Failed logs:
- https://luci-milo.appspot.com/buildbot/chromeos/tricky-chrome-pfq/4643
- https://luci-milo.appspot.com/buildbot/chromeos/lumpy-chrome-pfq/11408
- https://luci-milo.appspot.com/buildbot/chromeos/peach_pit-chrome-pfq/4824

 

Comment 1 by vpalatin@google.com, Jan 29 2018

Owner: xiy...@chromium.org
adding the Chrome gardener
AFAICT neither the browser_bridge.js code for isSandboxedForTesting() nor the  security_SandboxStatus autotest have changed for long time.

the gpuInfo code whose data seems to be used by the javascript above has changed around the timeframe of the failure:
https://chromium-review.googlesource.com/#/c/chromium/src/+/887349/
Cannot spot anything bad though but that's Chrome code, not anything I know

Comment 3 by xiy...@chromium.org, Jan 29 2018

Cc: newcomer@chromium.org

Comment 4 by xiy...@chromium.org, Jan 29 2018

Cc: xiy...@chromium.org
Owner: zmo@chromium.org
Status: Assigned (was: Available)
zmo@, looks like your CL (https://chromium-review.googlesource.com/#/c/chromium/src/+/887349/) could be the cause of the failure.

Particularly, in GpuDataManagerImplPrivate::UpdateGpuInfo, the |sandboxed| flag was kept when gpu info is updated. Think this would propagate down and could cause chrome://gpu page to return false for browserBridge.isSandboxedForTesting().

Please check. Thanks.

Comment 5 by xiy...@chromium.org, Jan 29 2018

Thanks zmo@ for the quick fix.

Fix in CQ now: https://chromium-review.googlesource.com/c/chromium/src/+/892088


Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48e31c1abc9d016c0d07ad32906094a31dc16733

commit 48e31c1abc9d016c0d07ad32906094a31dc16733
Author: Zhenyao Mo <zmo@chromium.org>
Date: Tue Jan 30 04:21:20 2018

Fix the GPUIno.sandboxed bit update.

BUG= 806669 
TEST=affected bots
R=piman@chromium.org,xiyuan@chromium.org
NOTRY=true

Change-Id: I954fc1f5cdcffe4d55ff41927b9b33075c9fd616
Reviewed-on: https://chromium-review.googlesource.com/892088
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532748}
[modify] https://crrev.com/48e31c1abc9d016c0d07ad32906094a31dc16733/content/browser/gpu/gpu_data_manager_impl_private.cc

Comment 7 by zmo@chromium.org, Jan 30 2018

Owner: xiy...@chromium.org
Need the CL to be rolled into chromeos for these bots to turn green.

Assign to xiyuan@ to keep an eye on the bots. When they turn green, please close the bug.

Thanks.
Status: Verified (was: Assigned)
PFQ passed for chrome 66.0.3336.3.

e.g. 
https://luci-milo.appspot.com/buildbot/chromeos/tricky-chrome-pfq/4669

Sign in to add a comment