New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806663 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Previously blocked permission bubble icon doesn't appear after clicking on 'Auto download' button.

Reported by vku...@etouch.net, Jan 29 2018

Issue description

Chrome Version:66.0.3334.0 (Official Build) dec7220f080ea5dc647603e2dd8092afe6bb302f-refs/heads/master@{#532207} (32/64-bit) 
OS: Win(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.3),Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://permission.site/ , click on https.
(2)Click on Location, Microphone & MIDI button and click on block button from each permission bubble such that blocked icon appears in omnibox.
(3)Now resize browser window from R.H.S, click on 'auto download' button > click on block from bubble.
(4)Observe the blocked icon in omnibox.

Actual: Previously blocked permission bubble doesn't appear after clicking on 'Auto download' button.

Expected: Previously blocked permission bubble should appear after clicking on 'Auto download' button.

This is a regression issue broken in 'M65' and below is the manual bisect info
Good Build: 65.0.3311.0 (Revision: 526880)
Bad Build:  65.0.3313.0 (Revision: 527467)

Note: This issue is seen on latest Dev Build #65.0.3325.18(Official build)
 
ActualResult.mp4
996 KB View Download
ExpectedResult.mp4
1001 KB View Download

Comment 1 by vku...@etouch.net, Jan 29 2018

Labels: hasbisect-per-revision RegressedIn-65 FoundIn-66 Target-66 Target-65 FoundIn-65
Owner: jochen@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 526983 (known good), but no later than 526984 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/b791621ba498326b3fea5afe92ae4e94baf5aee7..640b4e204bf8f07832bca2ef915ad06d06e65219

Suspecting: https://chromium.googlesource.com/chromium/src/+/640b4e204bf8f07832bca2ef915ad06d06e65219

@jochen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.

Comment 3 by jochen@chromium.org, Jan 29 2018

Cc: raymes@chromium.org benwells@chromium.org
well, it's just that this pattern no longer results in multiple downloads, so arguably, it's better than before?

note that the auto download button does nothing in firefox...

Raymes/Ben, how should we proceed here?

Comment 4 by raymes@chromium.org, Jan 30 2018

Components: -UI>Browser>Bubbles UI>Browser>Permissions>Indicators
Owner: ----
Status: Available (was: Assigned)
jochen: I think the bug being pointed out is that some of the page action icons disappear when the Automatic Downloads button is clicked. This is probably because we clear those icons when a navigation occurs and we probably aren't checking the right conditions on the "download" navigation. 

I'm not certain how the CL in the bisect affected it, but it looks like it's touching things related to navigation and downloads. It may not be the root cause.

Comment 5 by jochen@chromium.org, Jan 30 2018

Äh, makes sense. I changed <a download> to cause a navigation, so I guess this is expected.

I guess there's a more high-level question whether we should restore the icons if a navigation was aborted, e.g. because we decide to download instead.
Cc: bhthompson@chromium.org
Labels: OS-Chrome
Able to reproduce the issue on Chrome 65.0.3325.35/CrOS 10323.9.0 - Peppy,Paine
Labels: ET-MUM-Reported
Cc: jochen@chromium.org
Friendly ping to get an update on this issue as it is stable blocker for M65.

Still we are observing the same issue on latest Canary-66.0.3340.0 & dev-65.0.3325.31

jochen@, Please take a look into this issue.

Thanks..!
Labels: -ReleaseBlock-Stable
This is more or less a pre-existing issue, so let's drop the release block label
Labels: -Pri-1 Pri-2
Summary: Previously blocked permission bubble icon doesn't appear after clicking on 'Auto download' button. (was: Regression:Previously blocked permission bubble icon doesn't appear after clicking on 'Auto download' button.)

Sign in to add a comment