New issue
Advanced search Search tips

Issue 806660 link

Starred by 2 users
Status: Started
Owner:
lgrey@chromium.org
Cc:
nyerramilli@chromium.org
tapted@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : ‘Password’ bubble does not dismiss after clicking on ‘Key’ icon in omnibox.

Reported by avsha...@etouch.net, Jan 29 2018 
Chrome Version : 66.0.3334.0 (Official Build) dec7220f080ea5dc647603e2dd8092afe6bb302f-refs/heads/master@{#532207} 64-bit
OS : Mac(10.12.6, 10.13.1, 10.13.3)

Test URL : https://mail.google.com/mail/

What steps will reproduce the problem?
1. Launch chrome, navigate to above test URL and sign in to Gmail using valid credentials.
2. ‘Password’ bubble appears below omnibox after successful sign in.
3. Click on ‘key’ icon (seen in the omnibus at the RHS) to dismiss the ‘Password’ bubble.
4. Observe.

Actual Result : ‘Password’ bubble does not dismiss after clicking on ‘Key’ icon in omnibox.

Expected Result : The ‘Password’ bubble should get dismissed when user click on the ‘Key’ icon.

This is a regression issue broken in ‘M-66’ and will soon update the remaining info.
Good Build : 66.0.3328.0
Bad Build : 66.0.3329.0
Actual_Result.mov
3.2 MB View Download
Expected_Result.mov
2.7 MB View Download

Comment 1 by avsha...@etouch.net, Jan 29 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)
Providing the bisect results using ‘per-revision bisect’ script :
Good Build : 66.0.3328.0 (Revision : 530802)
Bad Build : 66.0.3329.0 (Revision : 531127)

You are probably looking for a change made after 530873 (known good), but no later than 530874 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/f7e99cf6fca9b86d824a168ab21a6c51cf1b854e..85b9d0662601895ecb6b25977ce3117725d0d525

Suspect : https://chromium.googlesource.com/chromium/src/+/85b9d0662601895ecb6b25977ce3117725d0d525

@vasilii : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note :
1. This is Mac OS specific issue and the same is working fine in Windows(7,8,8.1,10) and Linux(14.04 LTS) OS.
2. Issue is not reproducible in latest Dev #65.0.3325.18 and Beta #64.0.3282.119 build.

Comment 2 by nyerramilli@chromium.org, Jan 29 2018

Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 3 by vasi...@chromium.org, Jan 29 2018

Cc: tapted@chromium.org
tapted@, can I assume that the Cocoa bubbles are gone in M65?

Comment 4 by ellyjo...@chromium.org, Jan 29 2018 

No - the target date for Views bubbles to be enabled by default is M66, and even then, we want to retain the ability to turn them off if we need to.

Comment 5 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported

Comment 6 by ellyjo...@chromium.org, Feb 13 2018

Labels: -Pri-1 Pri-2
Owner: lgrey@chromium.org
Mac triage:

I think this bug is also live with the MacViews bubbles - my guess is that it's something like, the mousedown dismisses the bubble and the mouseup resummons it.

lgrey@, can you take a peek at this?

Comment 7 by ellyjo...@chromium.org, Feb 13 2018

Labels: -ReleaseBlock-Stable
Also, this isn't RBS.

Comment 8 by lgrey@chromium.org, Feb 13 2018

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed096ee3c49c29b4756f42df5af1901889a238ca

commit ed096ee3c49c29b4756f42df5af1901889a238ca
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Feb 16 21:11:33 2018

[Mac] Account for Harmony version of password bubble in closing logic

Bug: 806660
Change-Id: I8c9561b6f456db3fdea0bf31a65bf0af9321cb2c
Reviewed-on: https://chromium-review.googlesource.com/924341
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537413}
[modify] https://crrev.com/ed096ee3c49c29b4756f42df5af1901889a238ca/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
[modify] https://crrev.com/ed096ee3c49c29b4756f42df5af1901889a238ca/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm

Comment 10 by avsha...@etouch.net, Feb 22 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3352.0
Update : 
Verified above issue in latest Canary #66.0.3352.0 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screencast.

Thank you!
Canary_behavior.mov
3.4 MB View Download
►

Sign in to add a comment