New issue
Advanced search Search tips

Issue 806658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 715640



Sign in to add a comment

S13nServiceWorker: use tracing as a replacement for netlog

Project Member Reported by falken@chromium.org, Jan 29 2018

Issue description

netlog is currently the best debugging tool we have for reports in the wild.

We could use some sort of replacement for it for S13nSW. I'm not sure what this would look like. There may be plans for netlog for NetworkService in the works?

Alternatively, I guess we can ask users to do a trace. We just need to ensure the trace events are in place for S13nSW.
 

Comment 1 by falken@chromium.org, Jan 30 2018

Components: Blink>ServiceWorker

Comment 2 by falken@chromium.org, Feb 20 2018

I've heard Mojo loader features are doing away with netlog and will rely on tracing instead.

So we should make sure we have good trace instrumentation.
Summary: S13nServiceWorker: use tracing as a replacement for netlog (was: S13nServiceWorker: replacement for netlog, or tracing for debugging)

Comment 4 by falken@chromium.org, May 24 2018

Labels: Proj-Servicification-Canary

Comment 5 by dxie@chromium.org, Jun 5 2018

Labels: Proj-Servicification

Comment 6 by dxie@chromium.org, Jun 7 2018

Labels: -Proj-Servicification-Canary
@triaged, we don't believe this is blocking canary. removing the canary flag. If you believe this is needed for canary, please let us know.

Comment 8 by dxie@google.com, Jun 19 2018

Labels: Hotlist-KnownIssue
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9787ff6c470ae8c2b8317a3b7c7cf0aa406b4ee

commit c9787ff6c470ae8c2b8317a3b7c7cf0aa406b4ee
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri Jun 29 02:18:59 2018

Add TRACE_EVENTs for ServiceWorkerSubresourceLoader

Bug:  806658 
Change-Id: Ic69f20cf695db78e6cec1661d76904015f3d41e5
Reviewed-on: https://chromium-review.googlesource.com/1117959
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571364}
[modify] https://crrev.com/c9787ff6c470ae8c2b8317a3b7c7cf0aa406b4ee/content/renderer/service_worker/service_worker_subresource_loader.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95b394d6e9e62529b0ff96b3f6fef76a33efa48f

commit 95b394d6e9e62529b0ff96b3f6fef76a33efa48f
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jul 03 01:24:27 2018

Add TRACE_EVENTs for ServiceWorkerNavigationLoader

These traces will be shown up on the IO thread tasks, but we can easily follow each
event by clicking Incoming/Outgoing flow.

Bug:  806658 
Change-Id: I2de36f4741741e098dba28eab93606855d828551
Reviewed-on: https://chromium-review.googlesource.com/1119730
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572069}
[modify] https://crrev.com/95b394d6e9e62529b0ff96b3f6fef76a33efa48f/content/browser/service_worker/service_worker_navigation_loader.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/670a4fd7d5c89c8904f638edda72083e41e5d016

commit 670a4fd7d5c89c8904f638edda72083e41e5d016
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Jul 12 08:13:43 2018

NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

Bug:  806658 
Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
Reviewed-on: https://chromium-review.googlesource.com/1134711
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574503}
[modify] https://crrev.com/670a4fd7d5c89c8904f638edda72083e41e5d016/content/browser/service_worker/service_worker_navigation_loader.cc

Status: Fixed (was: Available)

Sign in to add a comment