New issue
Advanced search Search tips

Issue 806657 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression: Permission bubble disappears on minimizing the browser window to its last limit.

Reported by aiman.an...@etouch.net, Jan 29 2018

Issue description

Chrome Version:	66.0.3334.0 (Official Build) Revision dec7220f080ea5dc647603e2dd8092afe6bb302f-refs/heads/master@{#532207} (32/64-bit).
	
OS: Win(7,8,8.1,10) and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, go to https://permission.site, click on Notification.
2. When permission bubble is seen, minimize the browser window to its last limit and observe.

Actual: Permission bubble disappears on resizing the browser window.
Expected: Permission bubble should not disappear.

This is a regression issue, broken in M-63 series, Using the per-revision bisect providing the bisect results,

Good Build:63.0.3213.0(Revision:501133)
Bad Build:63.0.3214.0(Revision:501490)

You are probably looking for a change made after 501186 (known good), but no later than 501187 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/6dc789ca1ec1547a45e9c12615e4ed4ce2a515ab..6530629aa083b54a55670125ef60f8514efbd295

Suspect: https://chromium.googlesource.com/chromium/src/+/6530629aa083b54a55670125ef60f8514efbd295

timloh@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 1. This issue is also seen on M64 Stable/Beta (build #64.0.3282.119), M65 Dev(build #65.0.3325.18).
      2. Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.3).

Thank You!
 
Actual Result.mp4
1.1 MB View Download
Expected Result.mp4
1.2 MB View Download
Labels: RegressedIn-63 Target-65 FoundIn-66 Target-66 FoundIn-64 FoundIn-65 Target-64

Comment 2 by timloh@chromium.org, Jan 29 2018

Components: UI>Browser>Permissions>Prompts
This... seems ok to me, although I got different results when trying to repro:
- Windows 10, no hiding
- Linux, prompt cropped to the window
- CrOS, prompt hides only when vertically as small as possible

Comment 3 by raymes@chromium.org, Jan 30 2018

Components: Internals>Views
Ideally the behavior would be consistent but I think it's such low priority that we could just close this as WontFix since I don't expect we would get to it. 

It's kind of unclear to me why that CL would have caused a change though. timloh: do you know why? 

Comment 4 by timloh@chromium.org, Jan 30 2018

Status: WontFix (was: Assigned)
I assume WebContentsObserver::WasHidden is fired when a window becomes 0px high, but none of places that used to be hooked (OnActiveTabChanged/TabDetached/TabDeactivated) are called. On the Linux machine I tested, windows simply didn't resize down to 0px high.

Comment 5 by timloh@chromium.org, Jan 30 2018

To clarify, the windows themselves don't become 0px high, but rather the web contents.
Labels: ET-MUM-Reported

Sign in to add a comment