New issue
Advanced search Search tips

Issue 806645 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

http/tests/devtools/elements/elements-panel-rewrite-href.js is flaky

Project Member Reported by tikuta@chromium.org, Jan 29 2018

Issue description

Cc: devtools-dev@chromium.org
Components: Platform>DevTools
Labels: -Pri-3 OS-Windows Pri-1
Failed here for an unrelated change:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/105202

Another failure:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/105107

log seems to be:
13:59:26.948 8584 worker/0 http/tests/devtools/elements/elements-panel-rewrite-href.js output stderr lines:
13:59:26.948 8584   [13124:2452:0216/135924.590:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
13:59:26.948 8584   [9972:6464:0216/135924.859:ERROR:single_thread_proxy.cc(648)] NOT IMPLEMENTED
13:59:26.948 8584   [11932:4664:0216/135925.233:ERROR:single_thread_proxy.cc(648)] NOT IMPLEMENTED
13:59:26.948 8584 [1/1] http/tests/devtools/elements/elements-panel-rewrite-href.js failed unexpectedly (text diff)
13:59:26.948 8584 worker/0 http/tests/devtools/elements/elements-panel-rewrite-href.js failed:
13:59:26.948 8584 worker/0  text diff

Error messages look unrelated, as other tests seem to pass despite them.

Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4223ff36c3ec2502910e996a3dead22522144e39

commit 4223ff36c3ec2502910e996a3dead22522144e39
Author: Takuto Ikuta <tikuta@google.com>
Date: Fri Feb 23 10:01:55 2018

Mark elements-panel-rewrite-href.js is flaky

Following CLs retried due to the flakiness of this test.
https://chromium-review.googlesource.com/c/chromium/src/+/932446/2
https://chromium-review.googlesource.com/c/chromium/src/+/927524/3
https://chromium-review.googlesource.com/c/chromium/src/+/933501/1
https://chromium-review.googlesource.com/c/chromium/src/+/931990/1

Not sure, but looks unrelated to the test.
https://chromium-review.googlesource.com/c/chromium/src/+/932018/3
https://chromium-review.googlesource.com/c/chromium/src/+/918081/6
https://chromium-review.googlesource.com/c/chromium/src/+/926301/1

There are 43 tryjobs which failed in this test but success in retry in recent 3 days.

Note:
From the log of win7_chromium_rel_ng builder in recent 3 days,
* there are 1973 success tryjobs.
* there are 707 failure tryjobs.
* there are 331 failure webkit layout tests.

This CL will remove 5% of retry due to test flakiness.

No-Try: True
Bug:  806645 
Change-Id: Ib420c8ab051ef4aa9c37d6f37009ba6366952f32
Reviewed-on: https://chromium-review.googlesource.com/934041
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538743}
[modify] https://crrev.com/4223ff36c3ec2502910e996a3dead22522144e39/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b42617a59dfc7f4bb94ff2728b09173220b7ec27

commit b42617a59dfc7f4bb94ff2728b09173220b7ec27
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Apr 05 13:12:39 2018

Mark elements-panel-rewrite-href.js flaky on Mac

The test is failing quite regularly on Mac10.12, e.g:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/13210

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Felements%2Felements-panel-rewrite-href.js&showFlaky=true

The flakiness regressed recently on Mac10.12.

TBR=einbinder@chromium.org
NOTRY=true

Bug:  806645 
Change-Id: I14a6f37a4266e0d0eee35039f6765976f2fb2937
Reviewed-on: https://chromium-review.googlesource.com/997739
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548401}
[modify] https://crrev.com/b42617a59dfc7f4bb94ff2728b09173220b7ec27/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by l...@chromium.org, Jun 16 2018

Status: Fixed (was: Assigned)
The logs [1] show the error:
TypeError: Cannot read property 'nodeType' of null
	    at Elements.ElementsTreeOutline.findTreeElement (file:///b/s/w/ir/out/Release/resources/inspector/elements/elements_module.js:448:91)
	    at Elements.ElementsTreeOutline._innerUpdateChildren (file:///b/s/w/ir/out/Release/resources/inspector/elements/elements_module.js:614:173)


This was fixed as part of:  https://crbug.com/829884 

[1] https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/633921/site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

Comment 6 by l...@chromium.org, Jun 16 2018

Cc: -chenwilliam@chromium.org l...@chromium.org
Status: Assigned (was: Fixed)
Whoops, I was too eager to close this.  Although the error looks the same as the one in the fixed crbug, the flakiness dashboard still shows this test failing on Mac.  Sorry.
Status: Archived (was: Assigned)
Test failures are processed as a part of a dedicated triage, bulk-closing the bugs.

Sign in to add a comment