New issue
Advanced search Search tips

Issue 806640 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Disallow multiple keys in mb_config.pyl

Project Member Reported by tikuta@chromium.org, Jan 29 2018

Issue description

Can we have check for multiple keys in mb_config.pyl?

Context: https://chromium-review.googlesource.com/c/chromium/src/+/890687
 
Currently we just use ast.literal_expr() to read the file, which won't catch this. It would be possible (and is a good idea) to instead use the other ast methods and eval the dict directly, like we do now for gclient (in gclient_eval.py).
Labels: -mb Build-Tools-MB

Sign in to add a comment