LibFuzzer and AFL builds are broken due to angle roll |
|
Issue descriptionhttps://build.chromium.org/deprecated/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan/builds/8691 https://ci.chromium.org/buildbot/chromium.fyi/Afl%20Upload%20Linux%20ASan/7718 and others are broken since https://chromium.googlesource.com/chromium/src/+/8bda3f89b09c906505f805490ace821385cf5f03
,
Jan 29 2018
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/d1434c0481457fc50b6a275369987855f2172b1e commit d1434c0481457fc50b6a275369987855f2172b1e Author: Jamie Madill <jmadill@chromium.org> Date: Mon Jan 29 03:39:42 2018 Revert "Use ImmutableString for HLSL texture references" This reverts commit c13bda8678e86ff75a4acfc94f7a45e58224926d. Reason for revert: May have broken LibFuzzer and AFL builds: https://ci.chromium.org/buildbot/chromium.fyi/Afl%20Upload%20Linux%20ASan/7718 https://build.chromium.org/deprecated/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan/builds/8691 In file included from ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.cpp:12: In file included from ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.h:19: ../../third_party/angle/src/compiler/translator/InfoSink.h:40:16: error: call to function 'operator<<' that is neither visible in the template definition nor found by argument-dependent lookup stream << t; ^ ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.cpp:111:9: note: in instantiation of function template specialization 'sh::TInfoSinkBase::operator<<<sh::ImmutableString>' requested here out << textureReference; ^ ../../third_party/angle/src/compiler/translator/ImmutableString.h:76:15: note: 'operator<<' should be declared prior to the call site or in namespace 'sh' std::ostream &operator<<(std::ostream &os, const sh::ImmutableString &str); ^ 1 error generated. Bug: chromium:806619 Original change's description: > Use ImmutableString for HLSL texture references > > This also adds ImmutableStringBuilder class, which can be used to > build ImmutableStrings in place without extra allocations if the > maximum length is known in advance. > > BUG=angleproject:2267 > TEST=angle_unittests > > Change-Id: I4dfb78adeb0cffcfad0d25753fb8063466012c92 > Reviewed-on: https://chromium-review.googlesource.com/886362 > Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=jmadill@chromium.org,cwallez@chromium.org,oetuaho@nvidia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:2267 Change-Id: I445f5a786f8b16c3f40f28df09d45fcb215a9c88 Reviewed-on: https://chromium-review.googlesource.com/890542 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [delete] https://crrev.com/e762400446315bc7cf14d46047e1132a1f0360c3/src/compiler/translator/ImmutableStringBuilder.h [delete] https://crrev.com/e762400446315bc7cf14d46047e1132a1f0360c3/src/compiler/translator/ImmutableStringBuilder.cpp [modify] https://crrev.com/d1434c0481457fc50b6a275369987855f2172b1e/src/compiler/translator/TextureFunctionHLSL.cpp [modify] https://crrev.com/d1434c0481457fc50b6a275369987855f2172b1e/src/compiler/translator/ImmutableString.h [modify] https://crrev.com/d1434c0481457fc50b6a275369987855f2172b1e/src/compiler.gypi [modify] https://crrev.com/d1434c0481457fc50b6a275369987855f2172b1e/src/compiler/translator/UtilsHLSL.cpp [delete] https://crrev.com/e762400446315bc7cf14d46047e1132a1f0360c3/src/compiler/translator/ImmutableString.cpp [modify] https://crrev.com/d1434c0481457fc50b6a275369987855f2172b1e/src/compiler/translator/UtilsHLSL.h
,
Jan 29 2018
,
Jan 30 2018
Thanks Jamie! |
|
►
Sign in to add a comment |
|
Comment 1 by jmad...@chromium.org
, Jan 29 2018