New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Incorrect formatting for long url on the (https) error page

Project Member Reported by mar...@mwiacek.com, Jan 28 2018

Issue description

Device name: s7

From "Settings > About Chrome"
Application version:66.0.3331.0 canary
Operating system: 7

URLs (if applicable):https://3.141592653589793238462643383279502884197169399375105820974944592.com/

Steps to reproduce:
(1)open url

Expected result:


full url is breaking over long this way, that user doesn't have to scroll right to see it


Actual result:

url is not correctly formatted

Note: probably happens with other error messages too
 
Screenshot_20180127-195705.png
236 KB View Download
Screenshot_20180127-195848.png
185 KB View Download
Labels: Needs-triage-Mobile
Cc: sandeepkumars@chromium.org
Labels: M-66 Triaged-Mobile Type-Bug
Status: Untriaged (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. 

Steps Followed:
1. Launched the Chrome 
2. Navigated to https://3.141592653589793238462643383279502884197169399375105820974944592.com/
3. URL format is not proper

Chrome versions tested:
66.0.3334.0

OS:
Android 7.0.0

Android Devices:
Samsung S7 7.0.0

This is a Non-Regression issue as same behavior is seen since older builds.

Note: This issue is not observed in Desktop.

Thanks!!

Comment 3 by mar...@mwiacek.com, Jan 30 2018

Fix was proposed in the https://chromium-review.googlesource.com/c/chromium/src/+/893382
Screenshot_20180130-222212.png
212 KB View Download
Screenshot_20180130-222249.png
260 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4db4cd30a2de164262978718c75dd2cfd7f73235

commit 4db4cd30a2de164262978718c75dd2cfd7f73235
Author: marcin <marcin@mwiacek.com>
Date: Wed Jan 31 22:23:05 2018

Wrapping long texts (like domain names) on SSL error page

SSL error page doesn't wrap long texts, patch is fixing it.
For screenshots before and after please refer to the bug.

Bug:  806609 
Change-Id: I853c58286c62c1b2466477b31136074101045cdd
Reviewed-on: https://chromium-review.googlesource.com/893382
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Marcin WiÄ…cek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#533441}
[modify] https://crrev.com/4db4cd30a2de164262978718c75dd2cfd7f73235/components/security_interstitials/core/common/resources/interstitial_core.css

Comment 5 by mar...@mwiacek.com, Feb 1 2018

Cc: est...@chromium.org
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Sorry Emily, but I think that it would be good to add you on CC, maybe you could advice something?

I'm very confused and I need help from somebody who could look into this - there was done change (I don't see others in tree), change was tested (see above) and put into Canary, but... today Canary seems to have things behaving differently.

Could somebody build Chrome for me with all options like in Google Play to help checking if this change made problem ?

Increasing for P1 - I need to understand if this change should be somehow rollback or not.

Screenshot from Canary below
Screenshot_20180201-134016.png
249 KB View Download

Comment 6 by mar...@mwiacek.com, Feb 1 2018

I will try to do more investigation and put results here too...

Comment 7 by mar...@mwiacek.com, Feb 1 2018

hmmm, the most simple reasons are many times the correct one

It's probably false alarm - Canary 66.0.3336.0 is refs/heads/master@{#533409}, change is refs/heads/master@{#533441}

Waiting for new Canary

Emily, I'm removing you from CC and I'm sorry for mistake.

Comment 8 by mar...@mwiacek.com, Feb 1 2018

Cc: -est...@chromium.org
Labels: -Pri-1 Pri-3
Cc: est...@chromium.org
Owner: mar...@mwiacek.com
Status: Started (was: Available)
Just FYI: I'm waiting for new Canary and opened https://bugs.chromium.org/p/chromium/issues/detail?id=808049 because currently we have incorrectly formatted all possible error pages (problem seems to be much more generic than my simple fix).
My change seems to work in 66.0.3338.0, but I'm waiting for fixing another bug for  full result.
Status: Fixed (was: Started)

Sign in to add a comment