New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806582 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in get_scalar_from_data_ptr

Project Member Reported by ClusterFuzz, Jan 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4878190905131008

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x603000016c70
Crash State:
  get_scalar_from_data_ptr
  get_scalar
  get
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50698:50699

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4878190905131008

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 28 2018

Cc: malcolmwhite@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

De/serializes SharedArrayBuffers. by malcolmwhite@google.com - https://chromium.googlesource.com/v8/v8/+/982c3164033d3afd51c0d765fc4af98f22b5ccd4

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 28 2018

Labels: Pri-1

Comment 3 by ishell@chromium.org, Jan 29 2018

Cc: ishell@chromium.org yangguo@chromium.org
Owner: binji@chromium.org
Status: Assigned (was: Untriaged)
CF points to 982c3164033d3afd51c0d765fc4af98f22b5ccd4, PTAL.
Can't assign to the author: malcolmwhite@google.com.
Looking into this
Project Member

Comment 5 by ClusterFuzz, Jan 29 2018

Detailed report: https://clusterfuzz.com/testcase?key=4927243793727488

Job Type: windows_asan_d8_dbg
Crash Type: Heap-use-after-free READ 4
Crash Address: 0x11fc58bc3520
Crash State:
  v8::internal::ElementsAccessorBase<v8::internal::TypedElementsAccessor<v8::inter
  v8::internal::LookupIterator::FetchValue
  v8::internal::LookupIterator::GetDataValue
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4927243793727488

See https://github.com/google/clusterfuzz-tools for more information.

Comment 6 by mea...@chromium.org, Jan 29 2018

Labels: Security_Impact-Head

Comment 7 by binji@chromium.org, Jan 29 2018

FYI: It looks like the UAF only occurs in d8.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 30 2018

Labels: M-65
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 30 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1f2442ababce0c8792e278abc2b225e0d59d3ce5

commit 1f2442ababce0c8792e278abc2b225e0d59d3ce5
Author: Malcolm White <malcolmwhite@google.com>
Date: Tue Jan 30 23:12:20 2018

Fixes UAF for SAB with failed d8 serialization


Bug= chromium:806582 

Change-Id: I0d541903dfd1622ae6d4a2628c41dc28704680e6
Reviewed-on: https://chromium-review.googlesource.com/891626
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Malcolm White <malcolmwhite@google.com>
Cr-Commit-Position: refs/heads/master@{#50972}
[modify] https://crrev.com/1f2442ababce0c8792e278abc2b225e0d59d3ce5/src/d8.cc
[modify] https://crrev.com/1f2442ababce0c8792e278abc2b225e0d59d3ce5/src/d8.h

Project Member

Comment 11 by ClusterFuzz, Jan 31 2018

ClusterFuzz has detected this issue as fixed in range 50971:50972.

Detailed report: https://clusterfuzz.com/testcase?key=4927243793727488

Job Type: windows_asan_d8_dbg
Crash Type: Heap-use-after-free READ 4
Crash Address: 0x11fc58bc3520
Crash State:
  v8::internal::ElementsAccessorBase<v8::internal::TypedElementsAccessor<v8::inter
  v8::internal::LookupIterator::FetchValue
  v8::internal::LookupIterator::GetDataValue
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=50971:50972

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4927243793727488

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jan 31 2018

ClusterFuzz has detected this issue as fixed in range 50971:50972.

Detailed report: https://clusterfuzz.com/testcase?key=4878190905131008

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x603000016c70
Crash State:
  get_scalar_from_data_ptr
  get_scalar
  get
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50698:50699
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50971:50972

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4878190905131008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jan 31 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4878190905131008 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable -M-65 M-66
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 18 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M67 merge review. 
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Rejected-67
No merge needed.
Project Member

Comment 21 by sheriffbot@chromium.org, May 9 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment