Since this is a non-regression issue, Considering this as feature request and marking it as untriaged.

Deleted: 806577.png 43.1 KB

	806577.png 43.1 KB View Download

Thanks for pointing this out. Indeed it isn't a showstopper but certainly reduces the polish feeling from the product.

Lutz since you last touched the policy_templates target do you think it will be easy to fix this up?

There's a language_map in template_formatter.py that can be used for this. We currently use it to map out some naming differences on Mac. 

There's also the outputs definition in policy_templates.gni. It's probably cleanest there to define 3 language lists, one for the original files (e.g. 'de'), one for ADMX (e.g. 'de-DE') and one for Mac (e.g. 'de_DE').

I knew adding you to this CL will be a total hit! :)

CL is up: https://chromium-review.googlesource.com/c/chromium/src/+/893567

Can anyone test this on Mac? I'm wondering whether we have the same issue there.

Probably you did a little too much work? 

If we take a look into the must actual Windows 10 1709 ADMx files, MS themself shortened the list of supported languages of ADMl 
https://www.microsoft.com/de-DE/download/details.aspx?id=56121

The MSI (at least since 1607) is containing only:
cs-CZ,da-DK,de-DE,el-GR,en-US,es-ES,fi-FI,fr-FR,hu-HU,it-IT,ja-JP,ko-KR,nb-NO,nl-NL,pl-PL,pt-BR,pt-PT,ru-RU,sv-SE,zh-CN,zh-TW

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8e3d2917036aa936825b8d49575f15f950d14e

commit 7d8e3d2917036aa936825b8d49575f15f950d14e
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Jan 31 08:22:34 2018

Fix ADM/ADML folder names

ADMX files were not loaded into the GPO editor properly for most
languages because the directory names were bad, e.g. should be 'it-IT'
instead of 'it'. This CL fixes the directory names according to the doc
mentioned in the bug below.

For a few languages the mapping was not clear:
'am', 'fil', 'ml'  - Not in doc; kept the old directory names
'ar' -> 'ar-EG'    - Picked EG as the biggest of the ~15 Arabic countries
'bn' -> 'ms-BN'    - Is this correct? There's no bn-XX in the doc.
'sr' -> 'Cy-sr-SP' - Is this correct? Translations look cyrillic.

BUG= chromium:806577 
TEST=Changed components/policy/BUILD.gn to build for all platforms, ran
     ninja -C out/Release -j 2000 policy_templates
     Loaded de-DE into GPO editor on Windows

Change-Id: I574f6241b152c64943ec39442e2e23f7cae636cf
Reviewed-on: https://chromium-review.googlesource.com/893567
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533231}
[modify] https://crrev.com/7d8e3d2917036aa936825b8d49575f15f950d14e/components/policy/resources/policy_templates.gni
[modify] https://crrev.com/7d8e3d2917036aa936825b8d49575f15f950d14e/components/policy/resources/policy_templates.grd

Hmm, I just switched my Windows server (2012) to German (de-DE), but the templates in the 'de' folder load up fine, i.e. the folder doesn't have to be called 'de-DE' for this to work. Windows seems to be smart enough to fall back to 'de'.

Could you please explain what exactly is going wrong for you and what Windows version you're using?

Hi ljusten, 

probably it´s smart enough, but I would have 1 single file inside .\de, while 200+x reside in .\de-DE. It would always copy it manually to .\de-de.

If the folder name inside your zip is already .\de-DE Ican mark "chrome.admx" and "lang-foldername" and copy bot items in one step.
Otherwise I need to copy chrome.admx and .\de then move adml to de-de
or copy chrome.admx and in the next stept adml from inside.\ 
or rename .\de manually from the beginning and so on.

Anyway it would not fit my expectation from an tool that fit enterprise needs, just because the vendor is "not able" to prepare foldernames properly ;-)

It´s not a technical problem, it´s not even a real bug. It only irritates and is a little bit annoying, if you do this more than once a month as a consultant.

So if I understand correctly, nothing is really broken, you just get two directories, e.g. 'de-DE' and 'de'.

Anyway, the above CL should fix it. I made sure that the new directory names are a superset of the languages in the MSI, so we should be good.

Perfect!  Yes, thats right.

MSDN stated, this folder is [MUIculture].
https://msdn.microsoft.com/de-de/library/bb530196.aspx

I am not familiar with regex, the schema should explain it?
Group Policy ADMX Schema files
https://www.microsoft.com/en-us/download/details.aspx?id=4364

But, it would still lead into 2 folders. So better it´s fixed.

Thanks for the fast fix and recognition of my problem!
Mark