New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806539 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in net::QuicUrlUtilsImpl::GetPushPromiseUrl

Project Member Reported by ClusterFuzz, Jan 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5762368978812928

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  net::QuicUrlUtilsImpl::GetPushPromiseUrl
  net::QuicUrlUtils::GetPushPromiseUrl
  net::SpdyUtils::GetPromisedUrlFromHeaderBlock
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=532201:532202

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5762368978812928

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 27 2018

Components: Internals>Network>QUIC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 27 2018

Labels: Test-Predator-Auto-Owner
Owner: wangyix@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/734de9630d8fd39ed515f95f692ad1671097d6c5 (Make PUSH_PROMISE headers URL-parsing more robust and conform to HTTP/2 spec.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 28 2018

Labels: M-65
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 28 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 28 2018

Labels: Pri-1
Project Member

Comment 6 by ClusterFuzz, Jan 29 2018

ClusterFuzz has detected this issue as fixed in range 532267:532326.

Detailed report: https://clusterfuzz.com/testcase?key=5762368978812928

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  net::QuicUrlUtilsImpl::GetPushPromiseUrl
  net::QuicUrlUtils::GetPushPromiseUrl
  net::SpdyUtils::GetPromisedUrlFromHeaderBlock
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=532201:532202
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=532267:532326

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5762368978812928

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jan 29 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5762368978812928 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 8 by mmoroz@chromium.org, Jan 30 2018

Cc: nedwilli...@gmail.com infe...@chromium.org
Labels: reward-topanel
Adding reward-topanel label, as that fuzz target has been contributed by an external researcher: https://chromium-review.googlesource.com/c/chromium/src/+/753006


Comment 9 by mmoroz@chromium.org, Jan 30 2018

Labels: External-Fuzzer-Contribution
Cc: mmoroz@chromium.org
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
This was also hit internally.
Labels: -ReleaseBlock-Stable -M-65 M-66
Cc: mmenke@chromium.org
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 27 2018

Labels: Merge-Request-67
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M67 merge review. 
Labels: -Hotlist-Merge-Review -Merge-Review-67
Already in Chrome 66
Project Member

Comment 20 by sheriffbot@chromium.org, May 7 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment