New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806533 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 764659



Sign in to add a comment

In tricium plugin, visually distinguish results with findings.

Project Member Reported by qyears...@chromium.org, Jan 27 2018

Issue description

In the progress response, we already include the number of comments for each analyzer.

I imagine that we could display a small number after the analyzer name -- perhaps in a little box kind of like how LUCI is displayed in the buildbucket plugin UI.

Perhaps the title/alt of the box could say "N findings" or "N comments produced by this analyzer" to make it clearer what the number means.

If this is too much clutter, it may also be possible to use some other visual difference.
 
Blocking: 764659
Labels: Milestone-Progress
Proposed change: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/tricium/+/890635
Screenshot from 2018-01-29 09-27-40.png
58.3 KB View Download
Screenshot from 2018-01-29 09-27-24.png
65.3 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/fe567a81e1355d059ba93f0e889c24e2c775dcf9

commit fe567a81e1355d059ba93f0e889c24e2c775dcf9
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Jan 30 20:02:22 2018

Tricium plugin: Show number of comments after analyzer name

Reason: This would show quickly in one place which analyzers have
findings and which don't.

The visual style is copied from the "LUCI" chip in the buildbucket
plugin.

https://screenshot.googleplex.com/bywCD5EvfN9
https://screenshot.googleplex.com/nCE8k402ubC

Bug:  806533 
Change-Id: I7604c8bf5b80ec90225732e678b62d1fa425b358
Reviewed-on: https://chromium-review.googlesource.com/890635
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/fe567a81e1355d059ba93f0e889c24e2c775dcf9/src/main/resources/static/tricium-view.html
[modify] https://crrev.com/fe567a81e1355d059ba93f0e889c24e2c775dcf9/test/example.html

Status: Fixed (was: Assigned)
CL committed into upstream repo, not yet deployed to actual Gerrit.

Sign in to add a comment