Risk_report: TypeError when we can't reach CL-Scanner service. |
||
Issue descriptionGetCLRiskReport now returns a dictionary of step links, so we need to keep that consistent when we catch an exception.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/bb167004f675bc481a8d0e8141136dfac1a8f311 commit bb167004f675bc481a8d0e8141136dfac1a8f311 Author: Paul Hobbs <phobbs@google.com> Date: Tue Jan 30 00:38:28 2018 risk_report: Fix TypeError when unable to reach service The type of GetCLRiskReport is now int -> Dict[str, str], so we can't return a string when we encounter an exception trying to reach CL-Scanner. BUG= chromium:806529 TEST=unit test Change-Id: Ia2818c7d6558e466f773ee327878b34a6d1ce89d Reviewed-on: https://chromium-review.googlesource.com/890459 Commit-Ready: Paul Hobbs <phobbs@google.com> Tested-by: Paul Hobbs <phobbs@google.com> Reviewed-by: Paul Hobbs <phobbs@google.com> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/bb167004f675bc481a8d0e8141136dfac1a8f311/lib/risk_report.py
,
Jan 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by pho...@chromium.org
, Jan 29 2018