New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806525 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Null-dereference READ during FormatBlock command

Project Member Reported by ClusterFuzz, Jan 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4859500866830336

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000008
Crash State:
  blink::Node* blink::NodeTraversal::ChildAtTemplate<blink::Node const>
  blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >
  blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=488849:488980

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4859500866830336

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 27 2018

Components: Blink>DOM Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by rakina@chromium.org, Jan 29 2018

Status: Available (was: Untriaged)
Components: -Blink>Editing -Blink>DOM Blink>Editing>Command
Labels: -Pri-1 Pri-3
Summary: Null-dereference READ during FormatBlock command (was: Null-dereference READ in blink::Node* blink::NodeTraversal::ChildAtTemplate<blink::Node const>)
Applying P3 due to low real world usage of FormatBlock command.
Owner: tanvir.r...@samsung.com
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95586fb9630d1e2cf0f32b209169cc4a7c9b1501

commit 95586fb9630d1e2cf0f32b209169cc4a7c9b1501
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Tue Feb 13 03:53:46 2018

Fix for crash in formatBlock command

FormatBlock command crashes when format block
tries to insert node at a disconnected position.

This CL does a safety check and does insertion
only if the nodes are connected.

Bug:  806525 
Change-Id: Ie3cc803cfa09bd6013f291d374d792d88d89e49c
Reviewed-on: https://chromium-review.googlesource.com/913189
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536253}
[modify] https://crrev.com/95586fb9630d1e2cf0f32b209169cc4a7c9b1501/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp
[modify] https://crrev.com/95586fb9630d1e2cf0f32b209169cc4a7c9b1501/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

Project Member

Comment 6 by ClusterFuzz, Feb 13 2018

ClusterFuzz has detected this issue as fixed in range 536251:536255.

Detailed report: https://clusterfuzz.com/testcase?key=4859500866830336

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000008
Crash State:
  blink::Node* blink::NodeTraversal::ChildAtTemplate<blink::Node const>
  blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >
  blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=488849:488980
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=536251:536255

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4859500866830336

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Feb 13 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 4859500866830336 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment