New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806506 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Fullscreen video causes WindowServer crash in macOS 10.11

Reported by jono...@gmail.com, Jan 27 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36

Steps to reproduce the problem:
1. Open this https://www.youtube.com/watch?v=DX48mJjL7oU
2. Set it to view in 4k
3. Make it full screen

What is the expected behavior?
To view the video in fullscreen without issues

What went wrong?
Chrome crashes and forces MacOS to logout
Viewing the video in 4k@60fps not in full screen mode doesn't cause this to happen

Crashed report ID: No

How much crashed? Whole browser

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Chrome version: 64.0.3282.119  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

Hardware: MacBookPro12,1 with i5@2.7ghz and 16gb of ram 
OS: MacOS 10.11.6
 

Comment 1 by meh...@chromium.org, Jan 28 2018

Can you please attach the Apple crash log and/or the Server Crash ID from chrome://crashes here ?

Thanks.

Comment 2 by jono...@gmail.com, Jan 28 2018

I’ve searched but it doesn’t look to be here( the most recent one is from october 2017)

Jonathan

On 28 gen 2018, 10:08 +0100, meh… via monorail <monorail+v2.1119298406@chromium.org>, wrote:
Labels: Needs-Triage-M64
Labels: Needs-Feedback
This sounds like Chrome is causing a Window Server crash, which is quite bad. I wasn't able to repro the issue on my machine. Can you please provide:

1) GPU information by navigating a Chrome tab to about://gpu and saving the contents

2) The Window Server crash should be available in ~/Library/Logs/DiagnosticReports . Note that it's a hidden file. From the terminal, run 
"""
ls -alh ~/Library/Logs/DiagnosticReports/
"""
to see the full list of files there. 

3) After this happens, please compress and upload the file: 
"""
/var/log/system.log
"""

This will contain additional context for the crash.
Components: Internals>GPU
Labels: -Pri-2 Pri-1
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: sc00335...@techmahindra.com
 Issue 806599  has been merged into this issue.
Cc: sdy@chromium.org
We may want to get this into m64, given the severity.
Summary: Fullscreen video causes WindowServer crash in macOS 10.11 (was: Chrome causes a logout)
sdy managed to get a machine to reproduce this, and got it down to the range:

https://chromium.googlesource.com/chromium/src/+log/65.0.3324.0..66.0.3334.0?pretty=fuller&n=10000

sdy, can you check if reverting r530351 on a local build causes the issue to re-appear?
Yes, I think this would be sensible to merge back to M64 if we can pin down for certain what the issue is.

Comment 11 by sdy@chromium.org, Jan 30 2018

Re. c#9, yep, I'm working on that now.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9536f2fab4a57cb9669c80bc8a8475e1f2788e5

commit d9536f2fab4a57cb9669c80bc8a8475e1f2788e5
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Jan 30 23:21:40 2018

Disable AVFoundation on macOS <10.12

Fullscreen low power mode (which is triggered by use of AVFoundation)
is causing 10.11's WindowServer to crash.

Bug:  806506 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I40cfdfbd932be56cf0078c91cad824ee6895f9b6
Reviewed-on: https://chromium-review.googlesource.com/892097
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533072}
[modify] https://crrev.com/d9536f2fab4a57cb9669c80bc8a8475e1f2788e5/gpu/config/gpu_driver_bug_list.json

Comment 13 by sdy@chromium.org, Jan 30 2018

Reverting that commit does *not* cause the crash to re-appear.
Hmm... does th blacklist that I at landed do it?
Cc: ccameron@chromium.org
 Issue 806536  has been merged into this issue.
Labels: Merge-Request-64
Adding Merge-Request-64.

A bug in macOS 10.11 causes the system to (effectively) reboot when watching fullscreen video. The fix is very low risk and I advocate merging to 64 if there are any more builds being pushed.
Project Member

Comment 17 by sheriffbot@chromium.org, Feb 1 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for working on the fix. Can you please answer following:

1) How safe this merge is?
2) Is this well tested? 
3) Why is this needed for M64 vs waiting until M65? 
1. This is a very safe merge -- it adds an entry to the GPU blacklist
2. I'd like someone with a repro to re-verify it (sdy@ had a local repro), but I am confident this will fix the issue
3. The behavior (full crash of the system and logging out of the user when watching fullscreen video) started happening in M64 and needs to be fixed asap
Labels: Hotlist-ConOps
There's been 6 user reports in Feedback about this Mac crash.

Chrome crashes and restarts my Mac when I watch a video (on any website) in fullscreen mode. I've tested this on Safari and it doesn't crash my laptop there.

Full screen youtube watching leads to crash mac os It's similar at any video on youtube. This issue was introducing with tle last chrome update Please fix it ASAP

Hello, Full screen videos (youtube or dailymotion) crash Mac os X (El Capitan version 10.11.6)! Indeed when I start playing a video in full screen (via Chrome), after 4-5 seconds, the screen goes black, then Mac OS asks me to enter my user password ...

on chrome when ever i play a video on full screen my macbook will crash and sleep then wake up. forces me to login to my mac i need help


mac book pro Click to maximize window The program will crash Need to force close and reopen Watching web video double-click full screen, then the same bug Uncomfortable dead quickly update it

Comment 21 by sdy@chromium.org, Feb 2 2018

This is fixed for me in the *current* stable, 64.0.3282.140. Which is interesting.

https://chromium.googlesource.com/chromium/src/+log/64.0.3282.119..64.0.3282.140?n=10000

Comment 22 by sdy@chromium.org, Feb 2 2018

f8e519c1a446343d0f8200aa8817b2a9a512180f is the only commit that looks plausible to me — it was me fiddling with something that involved NSVisualEffectView. I wonder if getting the NSVisualEffectView off the screen is enough to fix this crash.

Comment 23 Deleted

Comment 24 Deleted

I originally reported    Issue 806536    which has been merged into this issue. I just updated to the latest stable release, Version 64.0.3282.140 (Official Build) (64-bit), and attempted to play the NSFW video I linked that caused OSX 10.11.6 to crash. I can also confirm that whatever change(s) were made, OSX did not crash when I attempted to play back the NSFW video that I reported earlier. Whatever change(s) you guys did, whether intentional to unintentional to fix the issue, it is very much appreciated!

ccameron@ - can you please confirm if this is still needed? Seems like per #21 is already fixed?
Status: Fixed (was: Assigned)
Okay, since stable seems to be stable now, let's just close this out.
Labels: -Merge-Review-64 Merge-Rejected-64

Sign in to add a comment