Issue metadata
Sign in to add a comment
|
Tab audio muting UI control resetting upon reloading of page
Reported by
madhar...@gmail.com,
Jan 27 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Enable 'Audio muting UI control' in chrome://flags 2. Mute audio from tab that is on a site with audio playback 3. Reload page on said tab What is the expected behavior? Audio should remain muted. What went wrong? Audio mute setting resets upon reload and audio starts playing again. Did this work before? Yes 63.0 Is it a problem with Flash or HTML5? N/A Does this work in other browsers? N/A Chrome version: 64.0.3282.119 Channel: stable OS Version: 6.3 Flash Version: Contents of chrome://gpu:
,
Jan 29 2018
Assigned to steimel@ for triage. Though, it sounds that this is WAI as using this toggle takes a different path. Is this correct?
,
Jan 29 2018
,
Jan 29 2018
I know why this isn't working, and the fix is simple, but I recall bringing it up at some point and I can't remember if/why we decided not to support this. +miu@ for discussion. Is there any reason for us to not add a check in SoundContentSettingObserver to not override the audio indicator mutings?
,
Jan 29 2018
I thought about it a bit more and now I remember that we had discussed was whether or not the audio indicator should now have "mute site" functionality or "mute tab" functionality. We decided to leave it as is since it was a deprecated experimental feature. I don't think we discussed whether or not it should be overridden by site muting, and I think it makes sense to add the one-line check to at least keep the existing functionality working. WDYT?
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08e823a59c72ef9ded0d6b7e902eedcf4133ab4d commit 08e823a59c72ef9ded0d6b7e902eedcf4133ab4d Author: Tommy Steimel <steimel@chromium.org> Date: Tue Jan 30 14:36:29 2018 Do not unmute when muted by audio indicator This CL adds a check in SoundContentSettingObserver to avoid unmuting a tab if muted by the audio indicator. Bug: 806482 Change-Id: I433c1fcb7a8e8034a9b100077e2f876e88a7d409 Reviewed-on: https://chromium-review.googlesource.com/891259 Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532861} [modify] https://crrev.com/08e823a59c72ef9ded0d6b7e902eedcf4133ab4d/chrome/browser/content_settings/sound_content_setting_observer.cc [modify] https://crrev.com/08e823a59c72ef9ded0d6b7e902eedcf4133ab4d/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
,
Jan 30 2018
,
Jan 31 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc2b0ebebd7c6da7eb3ae0e60f9677f2c1cd935e commit cc2b0ebebd7c6da7eb3ae0e60f9677f2c1cd935e Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jan 31 16:57:03 2018 Do not unmute when muted by audio indicator This CL adds a check in SoundContentSettingObserver to avoid unmuting a tab if muted by the audio indicator. Bug: 806482 Change-Id: I433c1fcb7a8e8034a9b100077e2f876e88a7d409 Reviewed-on: https://chromium-review.googlesource.com/891259 Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532861}(cherry picked from commit 08e823a59c72ef9ded0d6b7e902eedcf4133ab4d) Reviewed-on: https://chromium-review.googlesource.com/894997 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#199} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/cc2b0ebebd7c6da7eb3ae0e60f9677f2c1cd935e/chrome/browser/content_settings/sound_content_setting_observer.cc [modify] https://crrev.com/cc2b0ebebd7c6da7eb3ae0e60f9677f2c1cd935e/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by susanjun...@techmahindra.com
, Jan 29 2018