New issue
Advanced search Search tips

Issue 806461 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Tracking bug for PAC for managed networks

Project Member Reported by marchuk@chromium.org, Jan 27 2018

Issue description

PAC is not applied on managed devices on non-managed users.
Tracking for crbug.com/798553 and crbug.com/803728

#10:
In the meanwhile, as mentioned before, as a workaround:
1. Connect to *any* npon policy shared network (or configure one)
2. Go to the detauls page for the non policy shared network
3. Open the proxy section and heck "Allow proxies for shared networks" - that is exactly the same as the checkbox on the main page in the old settings.



The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc

commit a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 26 17:57:28 2018

Settings: Network proxy: fix 'allow shared proxies' visibility

This CL shows 'allow shared proxies' for device managed proxies
since these proxy settings may be subject to the
'use_shared_proxies' pref.

This also:
* Adds tests for the detail page, including a minor change to
  internet_detail_page.js to facilitate testing.
* Fixes a subtle bug in isNetworkPolicyControlled.

  CrSettingsInternetDetailPageTest.InternetDetailPage

Bug: 798553
Test: browser_tests --gtest_filter=\
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I918710e106606127ff1246dd4400125b4c291273
Reviewed-on: https://chromium-review.googlesource.com/881867
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531998}
[modify] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/chrome/browser/resources/settings/internet_page/network_proxy_section.js
[modify] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/chrome/test/data/webui/settings/internet_detail_page_tests.js
[modify] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc/ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.js

 
Cc: scott.ga...@rentokil-initial.com
Hi,

I'm not sure that this is really helping me with the problem that I logged. Within my organisation we use proxy servers, just connecting to another network isn't really an option for us. 
Hi,

I think i've carried out the tests that you require. 
1) I logged into the Chromebox.
2) I created and joined a Test network which was tethered to my mobile."ScottsTestNetwork", I joined that network and addedd the proxy.pac, I couldn't see a box for "Allow Shared Proxies". I went to a webpage bbc.co.uk, first the proxy.pac was selected and then it flipped back to direct..the webpage then correctly displayed as expected. See image "Connected to Test Network"
3) I then rejoined the corporate WiFi, net-internals carried on showing direct and I couldn't load the webpage. I hit re-apply settings, tried reloading the policy and there was no change. 

Please let me know if you need further information. 
Connected to Corporate Wifi.png
84.8 KB View Download
Connected to Test Network.png
84.0 KB View Download
Components: OS>Systems>Network Enterprise
Cc: ryutas@google.com
Let's track commit fa7613e0289b9e27506ca5d60798dac798e60c77 and when it appears in any build, test it (expect Always show 'Allow shared' toggle to appear in Scott's environment).


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa7613e0289b9e27506ca5d60798dac798e60c77

commit fa7613e0289b9e27506ca5d60798dac798e60c77
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 12 22:19:07 2018

Network config: Always show 'Allow shared' toggle for shared networks

The proxy config code is absurdly complicated. It turns out we can
not currently differentiate between scenarios where
'allow shared proxies' is applied and when it is not.

We should address this in crbug.com/662529, but for now we should
always show the toggle for shared networks.
Status: Fixed (was: Assigned)
Commit fa7613e0... initially landed in 66.0.3346.0
Merged to 65.0.3325.69 (as ee015e5e...).

Sign in to add a comment