note that CQ's event table will be redesigned and bbucket_id field will be renamed to something nicer, such as build_id

I'm a little confused about bbucket_id and build_id. IIUC, bbucket_id is the universal unique integer number, and build_id is the string of format "bucket/builder/number" which supports both Buildbot and Luci builds. Is that correct?

integer identifier is not universal. It works only for buildbucket. Right now CQ has only those.

/me regrets inventing universal build ids because once we are on LUCI (soon!), we don't need them

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0ae3fcdc24eb9e0f89d45148e10f706231d9cbef

commit 0ae3fcdc24eb9e0f89d45148e10f706231d9cbef
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Feb 06 00:39:19 2018

[test-results] Parse build_id form parameters from uploads.

The actual recipe steps still need to be updated to set this
before we have build_id in test_results BQ.

Bug:  806441 
Change-Id: Ia28fa96452012cbf7ff3d866d6db5034d2230407
Reviewed-on: https://chromium-review.googlesource.com/902797
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/0ae3fcdc24eb9e0f89d45148e10f706231d9cbef/go/src/infra/appengine/test-results/frontend/upload.go

Have another recipe-side change to actually specify the build_id so the uploader can pass it to the test-results server: https://chromium-review.googlesource.com/c/chromium/tools/build/+/903188 but I'm not so familiar with recipes. PTAL if you know recipes. 

The "./recipes.py test train" command seems to have modified a lot more files than would seem necessary. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/362c224649ecb28745dab5b68b0ac45c24bd83e7

commit 362c224649ecb28745dab5b68b0ac45c24bd83e7
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Feb 07 17:44:46 2018

[recipe modules] The test result uploader includes buildbucket build id

Bug:  806441 
Change-Id: I420fe1f157d3ca248ef2833dbd943b0854442c37
Reviewed-on: https://chromium-review.googlesource.com/903188
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/resources/json_results_generator.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/examples/full.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/test.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_directory_does_not_exist.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_affected_targets_only.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded.json
[add] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/examples/full.expected/upload_success_buildbucket_staging_server.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/api.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/resources/README.md
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_error_code.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded_non_json_buildbucket.json
[add] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/examples/full.expected/upload_success_buildbucket_public_server.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/__init__.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/resources/tests/upload_test_results_unittest.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/resources/tests/json_results_generator_unittest.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/flake.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/README.recipes.md
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.py
[modify] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json
[add] https://crrev.com/362c224649ecb28745dab5b68b0ac45c24bd83e7/scripts/slave/recipe_modules/test_results/examples/full.expected/upload_success_buildbucket_no_server.json

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/349237ef0323dfe9a4bfbd5deafbb43c02e8319b

commit 349237ef0323dfe9a4bfbd5deafbb43c02e8319b
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Feb 14 21:50:06 2018

[test-results] Get build_id from JSON, rather than form params.

Since that's where https://chromium-review.googlesource.com/903188 puts
it.

Bug:  806441 
Change-Id: Iea6d606f9c97b7af940c94d9ec21c61ac874a47c
Reviewed-on: https://chromium-review.googlesource.com/916633
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/349237ef0323dfe9a4bfbd5deafbb43c02e8319b/go/src/infra/appengine/test-results/frontend/event_logging.go
[modify] https://crrev.com/349237ef0323dfe9a4bfbd5deafbb43c02e8319b/go/src/infra/appengine/test-results/model/full_result.go
[modify] https://crrev.com/349237ef0323dfe9a4bfbd5deafbb43c02e8319b/go/src/infra/appengine/test-results/frontend/event_logging_test.go
[modify] https://crrev.com/349237ef0323dfe9a4bfbd5deafbb43c02e8319b/go/src/infra/appengine/test-results/frontend/upload.go

build_id is now being populated.