system-config-printer is not available on KDE/Plasma desktops
Reported by
dantt...@gmail.com,
Jan 27 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Try to print something 2. Click to change the printer 3. Click to manage your computer's printer 4. It will fail to launch 'system-config-printer' executable as it's not available on KDE/Plasma desktops What is the expected behavior? It should call "kcmshell5 kcm_printer_manager" executable What went wrong? On printer_manager_dialog_linux.cc there's a wrong assumptions that system-config-printer-kde should be used in KDE/Plasma Desktops, but that's not the case since 8 years ago. Did this work before? No Chrome version: 63.0.3239.132 Channel: stable OS Version: Ubuntu 17.10 Flash Version:
,
Jan 30 2018
An easier way to reproduce it: go to chrome://settings/printing and click "Printers". I can confirm nothing happens when system-config-printer isn't installed.
,
Jan 30 2018
We don't actually use system-config-printer-kde, as when we tested it years ago, we found it has issues. Instead, we just call system-config-printer, but I guess it's not a dependency for the Chrome package, so systems may not have it installed.
,
Jan 30 2018
Yes, the code does not call "system-config-printer-kde" but "system-config-printer", but they have been replaced in KDE/Plasma by print-manager (which I'm the author) and AFAIK even GNOME doesn't use it by default. So the default Printer manager in KDE/Plasma5 can be issued by "kcmshell5 kcm_printer_manager"
,
Jan 30 2018
I'm using KDE 4, where I would substitute in kcmshell4. Testing on Ubuntu 14.04 here, I see the print-manager package provides /usr/lib/kde4/kcm_printer_manager.so. When I run "apt-get remove print-manager" just to see what it would remove, apt removes just print-manager. This makes me think there is no guarantee that the KDE print-manager, as packaged on Ubuntu, is required for KDE. So maybe what we can do is try running "kcmshell[45] kcm_printer_manager" first when the DE is KDE, and if that fails, fall back to system-config-printer. WDYT?
,
Jan 30 2018
Environment var KDE_SESSION_VERSION=5 when running plasma5 (if that helps to decide whether to use kcmshell5 or kcmshell4)
,
Jan 31 2018
The code to check KDE_SESSION_VERSION already exists in //base. Personall, I think kcmshell5 -> kcmshell4 -> system-config-printer is a good fallback path.
,
Jan 31 2018
We distinguish between KDE 4 and 5, so we can pick the right kcmshellN command. See https://chromium-review.googlesource.com/#/c/chromium/src/+/896112
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12801af0ae72422abf64e3ad857d84a447c9626d commit 12801af0ae72422abf64e3ad857d84a447c9626d Author: Lei Zhang <thestig@chromium.org> Date: Wed Jan 31 23:15:52 2018 Linux: Prefer using KDE-specific printer manager. KDE has its own printer management UI software, and system-config-printer may not be available. BUG= 806432 Change-Id: I1a1a2c9f3f09e2e62688d2e6abbda893a5e90e86 Reviewed-on: https://chromium-review.googlesource.com/896112 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533469} [modify] https://crrev.com/12801af0ae72422abf64e3ad857d84a447c9626d/chrome/browser/printing/printer_manager_dialog_linux.cc
,
Jan 31 2018
,
Feb 1 2018
,
Feb 1 2018
Thanks
,
Feb 1 2018
As a general note, I've been either fixing some KDE-related bugs myself or CC'ing the right people, but I tend to stumble upon them by chance, as they tend to be filed without any Component and end up in a triaging black hole because Chromium's regular triagers use Ubuntu 14.04. Feel free to CC me in KDE-related bugs in the future so I can help fix things more quickly. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by susanjun...@techmahindra.com
, Jan 29 2018