New issue
Advanced search Search tips

Issue 806431 link

Starred by 2 users
Status: Fixed
Owner:
chfremer@chromium.org
Closed: Jan 2018
Cc:
alaoui....@gmail.com
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Enable image capture tests on Windows

Project Member Reported by chfremer@chromium.org, Jan 27 2018 
Existing image capture tests had been disabled with  Issue 633242 .
New test cases have been added for a new MediaFoundation code path with Issue 730068, but are currently not running on bots.

Task is to enable the tests and make sure they pass on the bots.

Note: Querying/Manipulating image capture controls on Windows DirectShow has shown issues with various webcam drivers in Beta builds and had to be disabled because of it, see  Issue 722038 . It is unclear if the existing tests will pass on Windows DirectShow. If they don't it is okay to keep them disabled and only enable for MediaFoundation.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1425e7bc1a43e8ae9804f5a660de6296578b5553

commit 1425e7bc1a43e8ae9804f5a660de6296578b5553
Author: Réda Housni Alaoui <alaoui.rda@gmail.com>
Date: Tue Jan 30 19:32:53 2018

Re-enable image capture tests on Windows

Image capture tests were disabled since  issue 633242 .
We think this was caused by the fact that bots were running webcam tests
concurrently.
Now that concurrency has been disabled for these tests on Windows, they
should pass.

Bug:  806431 
Change-Id: Ic836752abef240d622f13cc7c44883540e033cf7
Reviewed-on: https://chromium-review.googlesource.com/890518
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532992}
[modify] https://crrev.com/1425e7bc1a43e8ae9804f5a660de6296578b5553/content/browser/webrtc/webrtc_image_capture_browsertest.cc

Comment 2 by chfremer@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)
Nice. The tests have been picked up by the bots and so far there have been no failures:

https://ci.chromium.org/buildbot/chromium.webrtc/Win8%20Tester/40101
https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/24884

Comment 3 by alaoui....@gmail.com, Jan 30 2018 

Great !
►

Sign in to add a comment