New issue
Advanced search Search tips

Issue 806412 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

font-feature-settings should be serialized with double-quotes

Project Member Reported by cnardi@chromium.org, Jan 26 2018

Issue description

font-feature-settings is serialized with single-quotes, contradicting the behavior of Firefox and Edge, and contrary to the CSSOM spec for serializing strings. This should be changed to serialize with double-quotes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e484a3cc686a4c54870e178e4e170ccc43879855

commit e484a3cc686a4c54870e178e4e170ccc43879855
Author: Chris Nardi <cnardi@chromium.org>
Date: Mon Jan 29 01:21:36 2018

Use double-quotes when serializing font-feature-settings

According to the CSSOM spec
(https://drafts.csswg.org/cssom/#common-serializing-idioms), all
strings should be serialized with double-quotes. The feature tag value
was previously serialized with single-quotes; change this to
double-quotes to match the spec and non-WebKit browsers.

Bug:  806412 
Change-Id: I5a93cc6add285aff46184c238b180e7617750702
Reviewed-on: https://chromium-review.googlesource.com/889909
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532298}
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/css3/font-feature-settings-parsing-expected.txt
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/css3/font-feature-settings-parsing.html
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/css3/fonts/font-feature-settings-parsing-prefixed.html
[add] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/external/wpt/css/css-fonts/font-feature-settings-serialization-001.html
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/fast/css/fontface-properties-expected.txt
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/fast/css/fontface-properties.html
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/LayoutTests/fast/css/inherited-properties-rare-text-expected.txt
[modify] https://crrev.com/e484a3cc686a4c54870e178e4e170ccc43879855/third_party/WebKit/Source/core/css/CSSFontFeatureValue.cpp

Comment 2 by cnardi@chromium.org, Jan 29 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ddbcb08896ee7e472115a985456eeb7e8304f8

commit 08ddbcb08896ee7e472115a985456eeb7e8304f8
Author: Chris Nardi <cnardi@chromium.org>
Date: Tue Feb 06 21:48:15 2018

Serialize font-variation-settings with double-quotes

According to the CSSOM spec [1], all strings should be serialized with
double-quotes. The axis name in font-variation-settings was previously
serialized with single-quotes; change this to double-quotes to match
the spec and non-WebKit browsers.

[1]: https://drafts.csswg.org/cssom/#common-serializing-idioms

Bug:  806412 
Change-Id: Ib0da551c2799a9dc4e273ac150972a7bd5c7a34f
Reviewed-on: https://chromium-review.googlesource.com/900843
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534803}
[modify] https://crrev.com/08ddbcb08896ee7e472115a985456eeb7e8304f8/third_party/WebKit/LayoutTests/fast/css/resources/font-variation-settings-css-support.js
[modify] https://crrev.com/08ddbcb08896ee7e472115a985456eeb7e8304f8/third_party/WebKit/Source/core/css/CSSFontVariationValue.cpp

Sign in to add a comment