📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/11f6f74a840000

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11f6f74a840000

Rewrite WebContentsVideoCaptureDevice, to use new VIZ-based capture impl
By miu@chromium.org · Thu Jan 25 02:23:58 2018
chromium @ 77e19b91361effda2f4eb9f278d9e038aca58d7c

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

miu: Looks like your CL broke performance_browser_tests. Can you revert or fix? If not, we'll want to disable the test to green up the waterfall.

I keep landing the fix, but because of some random nonsense (e.g., a buggy OpenGL library that fails only on MSAN on CrOS), the fix keeps getting reverted. I am re-landing hopefully for the last time. Thanks for your patience on this! :)

In CQ: https://chromium-review.googlesource.com/c/chromium/src/+/891541

Change landed. So, I expect the next run to succeed.

If the problem persists, I'll land a change to disable the perf_browser_tests while RCR'ing instead of reverting anything else (which is needed to keep things green elsewhere).

FYI--The change was this one:

https://chromium-review.googlesource.com/891541 (rev 532598)

Ah! I just noticed the "novsync" tests no longer apply to the new implementation. I'll disable those, and then we should be good to go.

In CQ now: https://chromium-review.googlesource.com/c/chromium/src/+/892049

Sorry I did not catch this earlier.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e179c6a28dbbb4c0e006c4726940ff4e98c2eedd

commit e179c6a28dbbb4c0e006c4726940ff4e98c2eedd
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Jan 29 23:27:41 2018

Remove novsync variants of performance_browser_tests.

Removes the "nosync" testing since this no longer applies to the new tab
capture impl (because it is necessarily triggered by OnBeginFrame's).
Also, added a call to BrowserTestBase::UseSoftwareCompositing() when the
non-GPU variants are run to ensure the GPU compositor is not being used.

TBR=xjz@chromium.org

Bug:  806400 , 567848
Change-Id: I1d00a5f95ee6d3ac8caf0e5d1191c7bb03ca8064
Reviewed-on: https://chromium-review.googlesource.com/892049
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532654}
[modify] https://crrev.com/e179c6a28dbbb4c0e006c4726940ff4e98c2eedd/chrome/browser/extensions/api/cast_streaming/performance_test.cc
[modify] https://crrev.com/e179c6a28dbbb4c0e006c4726940ff4e98c2eedd/chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc

Just checked...The current builds are failing on the same error, but they haven't picked up the fix yet. So, I expect this to be resolved on the next round. I'll come back after 4 hours and check again before resolving this bug.

Mac Air 10.11 was the first bot to build and successfully run the tests after the fix landed. Will check on the others tomorrow to verify.

All fixed! :)