Stop using content_browser service on Android WebView |
||||||||
Issue descriptionSafeBrowsing is currently registered under service content_browser on Android WebView. As spellchecker is being mojofied, SpellCheckHost will also be registered under service content_browser (crrev.com/c/846370). This is a hacky approach. We should use a dedicated service on WebView for them.
,
Feb 9 2018
In Chrome, spellcheck is registered under chrome_service (which is correct), but safebrowsing is registered under content_browser (which is a hack). For more background, see @yzshen's comment in crrev.com/c/846370 "Because both spellcheck and safebrowsing are chrome-level (or more accurately, embedder-level) concepts, instead of content-level concepts. Content doesn't know anything about them. So it is layer violation to register those features under "content_browser". I am fine with this as a short-term solution (well, I was the one who registered safebrowsing under content_browser :P). But eventually we should put them in the right service."
,
Feb 15 2018
,
Feb 22 2018
xiaochengh@ Is this a task you should own?
,
Feb 23 2018
cmasso@: I don't think so. I don't work on Mojo or servicification, and don't have enough knowledge about them. I'm mostly copy-pasting the issue yzshen@ identified.
,
May 1 2018
,
Dec 28
,
Jan 7
,
Jan 7
Based on the discussion in chromium-mojo, we are still adding new features to content overlay. https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/G2lZfJKP4Kw/xp0t2apxDwAJ Assign to myself as I experimented adding WebView service http://crrev/c/1398822 Removing yzshen@, since they are not working on Chromium anymore.
,
Jan 7
content_browser provides a lot of things that webview implicitly still uses via content_renderer. I assume you mean introducing a separate service for WebView-only features in addition to contnent_browser, rather than stopping use of content_browser altogether. Right?
,
Jan 7
Re #10, yes, this issue is for tracking add a separate service for WebView-only features. yzshen@'s point was since SafeBrowsing and SpellCheck are embedder level concepts, they shouldn't go with content service, instead we should have a embedder level service as Chrome do to host these features. Issue 918065 is purely WebView only feature, if we use the same judgement, it should go with WebView service too. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by boliu@chromium.org
, Feb 9 2018