HostFrameSinkManager provides observer to notify when a new FrameSinkManager has been created (recovery after a VIZ process crash) |
||||||||
Issue descriptionSo that the FrameSinkVideoCaptureDevice (client of viz::FrameSinkVideoCapturer) can gracefully auto-recover after VIZ process crashes, we need to add an observer scheme to HostFrameSinkManager. Ideally, once a new FrameSinkManager has been created after a crash, a callback would notify FSVCDevice that it should re-create the capturer using the new FrameSinkManager.
,
Feb 1 2018
,
Feb 1 2018
,
Feb 7 2018
,
Feb 7 2018
,
Feb 7 2018
,
Feb 9 2018
Note: The DevTools tracing snapshots is also going to use the viz::FrameSinkVideoCapturer; so we should make sure that code registers itself as an observer for these events as well. See: https://chromium-review.googlesource.com/c/chromium/src/+/909965
,
May 18 2018
samans@ is looking at this.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baecc27961585a9f936fa997e67fe8b9b3d7fab3 commit baecc27961585a9f936fa997e67fe8b9b3d7fab3 Author: Saman Sami <samans@chromium.org> Date: Thu May 24 00:43:19 2018 viz: Make sure video capture resumes after viz crash This CL introduces ClientFrameSinkVideoCapturer, a client-side library that interacts with FrameSinkVideoCapturer and can handle viz crashes. This CL converts FrameSinkVideoCaptureDevice to use ClientFrameSinkVideoCapturer but the DevTools usages of FrameSinkVideoCapturer aren't converted yet. Bug: 806377 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I982ca324491fafe9331de4b660cb81f93fcc4605 Reviewed-on: https://chromium-review.googlesource.com/1066224 Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561341} [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/components/viz/host/BUILD.gn [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/components/viz/host/DEPS [add] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/components/viz/host/client_frame_sink_video_capturer.cc [add] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/components/viz/host/client_frame_sink_video_capturer.h [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/content/browser/media/capture/aura_window_video_capture_device.cc [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/content/browser/media/capture/aura_window_video_capture_device.h [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/content/browser/media/capture/frame_sink_video_capture_device.cc [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/content/browser/media/capture/frame_sink_video_capture_device.h [modify] https://crrev.com/baecc27961585a9f936fa997e67fe8b9b3d7fab3/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2dc25f36f05e5e85e3d12738cc841e21c036786 commit d2dc25f36f05e5e85e3d12738cc841e21c036786 Author: Saman Sami <samans@chromium.org> Date: Thu May 24 20:41:07 2018 Use ClientFrameSinkVideoCapturer in DevToolsEyeDropper ClientFrameSinkVideoCapturer will survive gpu crashes. Bug: 806377 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I53492851e1092729a3e331fddabf69602e1a0dc7 Reviewed-on: https://chromium-review.googlesource.com/1071769 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561613} [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/chrome/browser/devtools/BUILD.gn [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/components/viz/host/host_frame_sink_manager.cc [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/components/viz/host/host_frame_sink_manager.h [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/d2dc25f36f05e5e85e3d12738cc841e21c036786/content/public/browser/render_widget_host_view.h
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4c3ee7ca5bece83c7f59ed25a21cb77188fa6c9 commit a4c3ee7ca5bece83c7f59ed25a21cb77188fa6c9 Author: Saman Sami <samans@chromium.org> Date: Fri May 25 19:38:07 2018 Use ClientFrameSinkVideoCapturer in DevToolsVideoConsumer ClientFrameSinkVideoCapturer survives gpu crashes. Bug: 806377 Change-Id: Ibef855c77440ef8098ebd7d1aaed4c5d39d32e29 Reviewed-on: https://chromium-review.googlesource.com/1072414 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#561972} [modify] https://crrev.com/a4c3ee7ca5bece83c7f59ed25a21cb77188fa6c9/content/browser/devtools/devtools_video_consumer.cc [modify] https://crrev.com/a4c3ee7ca5bece83c7f59ed25a21cb77188fa6c9/content/browser/devtools/devtools_video_consumer.h [modify] https://crrev.com/a4c3ee7ca5bece83c7f59ed25a21cb77188fa6c9/content/browser/devtools/devtools_video_consumer_unittest.cc
,
May 25 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kylec...@chromium.org
, Jan 26 2018Status: Assigned (was: Available)