New issue
Advanced search Search tips

Issue 806340 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 806343
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Add c++ deps (canary)

Reported by juanka85...@gmail.com, Jan 26 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. Build it
2. See the error
3. 

What is the expected behavior?
Build succesfully

What went wrong?
It needs some deps

Did this work before? N/A 

Chrome version: 63.0.3239.108  Channel: canary
OS Version: 66.0.3332.0
Flash Version: 

Attachment contains the fix
 
k2.patch
372 bytes Download
k1.patch
309 bytes Download
for now,  its just copy and paste these patches to chromium code    


system: linux - glibc
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
In k1.patch, that file has already included math.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f63f94a11abc34d40ede8b8712fa15b5844a8c0

commit 9f63f94a11abc34d40ede8b8712fa15b5844a8c0
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Jan 27 20:03:37 2018

Fix build with glibc 2.27

BUG= 806340 
TBR=hamelphi@chromium.org

Change-Id: Ib4e5091212d874d9ad88f3e9a1fdfee3ed7e0d5e
Reviewed-on: https://chromium-review.googlesource.com/890059
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Philippe Hamel <hamelphi@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532249}
[modify] https://crrev.com/9f63f94a11abc34d40ede8b8712fa15b5844a8c0/components/assist_ranker/ranker_example_util.cc

Mergedinto: 806343
Status: Duplicate (was: Assigned)

Sign in to add a comment