New issue
Advanced search Search tips

Issue 806334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Support non-raw image formats in cros_vm

Project Member Reported by norvez@chromium.org, Jan 26 2018

Issue description


cros_vm hardcodes the image format to raw since it's what image_to_vm.sh creates. However it can be useful to convert the image to other formats. For example, creating a qcow2 file backed by the raw image allows to run experiments on the VM without modifying the original raw image.
cros_vm should let the user specify a different image format.

 
Components: Internals>Skia

Comment 2 by norvez@chromium.org, Jan 26 2018

Components: -Internals>Skia Infra>Client>ChromeOS
Labels: -Pri-3 Pri-2
Let me know if you need help running the script or run into any difficulties with it.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f527cdf65209a2fa14664a72dc1f4f3425dab696

commit f527cdf65209a2fa14664a72dc1f4f3425dab696
Author: Nicolas Norvez <norvez@chromium.org>
Date: Sat Jan 27 12:14:31 2018

cros_vm: Support non-raw image formats

Let the user choose the format of the image (e.g. qcow2) instead of
forcing it to raw with the --image-format option. The default is still
'raw'

BUG= chromium:806334 
TEST=cros_vm --start still passes the raw format to qemu
TEST=cros_vm --start --image-format qcow2 passes the qcow2 format to
qemu

Change-Id: Ida938c485089557c5e7e11f9b936ffb784266eea
Reviewed-on: https://chromium-review.googlesource.com/888264
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f527cdf65209a2fa14664a72dc1f4f3425dab696/scripts/cros_vm.py

Comment 5 by norvez@chromium.org, Jan 29 2018

Status: Fixed (was: Started)

Sign in to add a comment